unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master 0ff58f6 12/12: Partially revert the defmethod->cl-defmethod change in registry.el
       [not found] ` <E1aU70m-0007j1-1N@vcs.savannah.gnu.org>
@ 2016-02-12 13:29   ` Stefan Monnier
  2016-02-13  2:58     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2016-02-12 13:29 UTC (permalink / raw)
  To: emacs-devel; +Cc: Lars Ingebrigtsen

>     * lisp/gnus/registry.el (initialize-instance): Use defmethod,
>     since cl-defmethod doesn't work with :after.
>     (initialize-instance): Ditto, but with :before.

AFAIK cl-defmethod works just fine with :after and :before.
OTOH, it doesn't work with :AFTER and :BEFORE, indeed.


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Emacs-diffs] master 0ff58f6 12/12: Partially revert the defmethod->cl-defmethod change in registry.el
  2016-02-12 13:29   ` [Emacs-diffs] master 0ff58f6 12/12: Partially revert the defmethod->cl-defmethod change in registry.el Stefan Monnier
@ 2016-02-13  2:58     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-13  2:58 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>     * lisp/gnus/registry.el (initialize-instance): Use defmethod,
>>     since cl-defmethod doesn't work with :after.
>>     (initialize-instance): Ditto, but with :before.
>
> AFAIK cl-defmethod works just fine with :after and :before.
> OTOH, it doesn't work with :AFTER and :BEFORE, indeed.

Heh.  My commit message said the opposite of the change I did,
apparently...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-13  2:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160212061418.24403.55552@vcs.savannah.gnu.org>
     [not found] ` <E1aU70m-0007j1-1N@vcs.savannah.gnu.org>
2016-02-12 13:29   ` [Emacs-diffs] master 0ff58f6 12/12: Partially revert the defmethod->cl-defmethod change in registry.el Stefan Monnier
2016-02-13  2:58     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).