From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 0883e98 1/3: New functions for getting and setting image properties
Date: Mon, 22 Feb 2016 17:37:13 +0100 [thread overview]
Message-ID: <8737skitvq.fsf@web.de> (raw)
In-Reply-To: <87h9h0ant0.fsf@web.de> (Michael Heerdegen's message of "Mon, 22 Feb 2016 14:15:39 +0100")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Looks ok. Nitpick: according to the doc of `gv-define-simple-setter',
> to "preserve the semantics of setf" `image--set-property' should either
> return the VALUE. Or use
>
> (declare (gv-setter image--set-property t))
> ^
>
> Hmm, this DTRT, though it's not documented in
>
> (info "(elisp) Declare Form")
>
> Will file a bug report...
Done - see bug#22766: 25.0.91; (info "(elisp) Declare Form"): gv-setter:
mention FIX-RETURN arg
Stefan suggests to change `image--set-property' to return the VALUE
instead of using the undocumented optional second arg of the gv-setter
declare form.
Michael.
next prev parent reply other threads:[~2016-02-22 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160220070344.25183.28197@vcs.savannah.gnu.org>
[not found] ` <E1aX1a8-0006a1-FW@vcs.savannah.gnu.org>
2016-02-20 7:28 ` master 0883e98 1/3: New functions for getting and setting image properties Lars Ingebrigtsen
2016-02-20 17:00 ` Michael Heerdegen
2016-02-21 2:29 ` Lars Ingebrigtsen
2016-02-21 11:55 ` Michael Heerdegen
2016-02-22 1:40 ` Lars Ingebrigtsen
2016-02-22 13:15 ` Michael Heerdegen
2016-02-22 16:37 ` Michael Heerdegen [this message]
2016-02-23 1:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737skitvq.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).