Re: [PATCH] Extra information in autoload error

[Alex <agrambot@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Alex <agrambot@gmail.com>
>> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
>> Date: Mon, 24 Oct 2016 13:21:08 -0600
>> 
>> Here, fundef is the autoload object. That is, it's a list of the form:
>> 
>>   (autoload filename docstring interactive type)
>> 
>> So SDATA (Fcar (Fcdr (fundef))) just gets the filename of the autoload
>> object. The filename of the autoload object is just the 2nd argument of
>> the `autoload' function.
>> 
>> So the Vload_history version returns the whole path, while the fundef
>> version just uses whatever was passed into autoload. Usually that is
>> just the filename sans extension, e.g.:
>> 
>> (symbol-function 'linum-mode) => (autoload "linum" 1174895 t nil)
>
> I think the file name alone will be enough.  Having a full absolute
> file name would be nicer, though.  I see no need for anything else:
> just the file name and the feature that was supposed to be autoloaded.
>
> Thanks.

Alright, I've attached a patch that includes both the absolute file name
and feature. If it's agreeable, then would you apply it for me?

Just to be clear, the autoload (autoload 'linum2 "linum") with this
patch will produce something like:

(error "Autoloading file /home/alex/emacs/lisp/linum.elc failed to
define function linum2")


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 856 bytes --]

From e8e8544b1805d474921974faa92d040699074878 Mon Sep 17 00:00:00 2001
From: Alexander Gramiak <agrambot@gmail.com>
Date: Mon, 24 Oct 2016 23:20:54 -0600
Subject: [PATCH] Add extra information in autoload error

* src/eval.c (Fautoload_do_load): Include the absolute file name in the
  error.
---
 src/eval.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/eval.c b/src/eval.c
index a9bad24..caeb791 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -1988,7 +1988,8 @@ it defines a macro.  */)
       Lisp_Object fun = Findirect_function (funname, Qnil);
 
       if (!NILP (Fequal (fun, fundef)))
-	error ("Autoloading failed to define function %s",
+	error ("Autoloading file %s failed to define function %s",
+	       SDATA (Fcar (Fcar (Vload_history))),
 	       SDATA (SYMBOL_NAME (funname)));
       else
 	return fun;
-- 
2.9.3