From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: Brave new mark-defun (and a testing tool) Date: Mon, 13 Feb 2017 16:58:47 +0100 Message-ID: <8737fihyko.fsf@mbork.pl> References: <87o9ydrzkr.fsf@mbork.pl> <87mvdriuss.fsf@mbork.pl> <87bmu6icea.fsf@mbork.pl> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487001500 23219 195.159.176.226 (13 Feb 2017 15:58:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Feb 2017 15:58:20 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 26.0.50.3 Cc: John Wiegley , Emacs developers To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 13 16:58:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdJ14-0005eI-El for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 16:58:14 +0100 Original-Received: from localhost ([::1]:57815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdJ1A-0001R5-6R for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2017 10:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdJ10-0001PG-Gx for emacs-devel@gnu.org; Mon, 13 Feb 2017 10:58:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdJ0x-0004h4-KQ for emacs-devel@gnu.org; Mon, 13 Feb 2017 10:58:10 -0500 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:36066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdJ0x-0004g9-DX for emacs-devel@gnu.org; Mon, 13 Feb 2017 10:58:07 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 92639E6A3F; Mon, 13 Feb 2017 16:58:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6PMRQWfj2yvR; Mon, 13 Feb 2017 16:58:03 +0100 (CET) Original-Received: from localhost (unknown [83.13.149.242]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 4D7C3E668F; Mon, 13 Feb 2017 16:58:03 +0100 (CET) In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.110.48.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212340 Archived-At: On 2017-02-13, at 16:16, Dmitry Gutov wrote: > On 13.02.2017 13:00, Marcin Borkowski wrote: > >>>> mark-defun is now extensively tested - it comes with a suite of about two >>>> dozen ert tests. >>> >>> Well, you've sold me there. :) >> >> Well, don't make fun of a humble mathematician. :-) > > I'd rather interpret John as being entirely serious. :) Tests are good. I'm not sure either way. That's why I put a smiley in my response, too;-). >> Also, I only tested it in Elisp mode. That's a potential problem... > > I'm not a frequent user of mark-defun, so I can miss edge cases, but I > see the improvement. Thanks! > > Tested in emacs-lisp-mode and ruby-mode. Thanks a lot. Python might be especially problematic (see comments in code for why). Best, -- Marcin Borkowski