From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH]: Add new bytecode op `switch' for implementing branch tables. Date: Fri, 10 Feb 2017 12:47:39 -0800 Organization: UCLA Computer Science Department Message-ID: <87379c26-6116-a45d-8205-b9d00e8b6c90@cs.ucla.edu> References: <1b07c68a-873e-83c8-246d-423bc83a3881@gmail.com> <712df469-190d-aeab-e239-1f225be3333f@gmail.com> <25a6003d-1d9b-381f-29b0-aece30af1def@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1486759707 19912 195.159.176.226 (10 Feb 2017 20:48:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2017 20:48:27 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: "emacs-devel@gnu.org" To: Vibhav Pant , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 10 21:48:23 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccI7C-0004gK-If for ged-emacs-devel@m.gmane.org; Fri, 10 Feb 2017 21:48:22 +0100 Original-Received: from localhost ([::1]:45887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccI7E-0006j7-RL for ged-emacs-devel@m.gmane.org; Fri, 10 Feb 2017 15:48:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccI6d-0006ip-1h for emacs-devel@gnu.org; Fri, 10 Feb 2017 15:47:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccI6Z-0004Vl-VN for emacs-devel@gnu.org; Fri, 10 Feb 2017 15:47:47 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35380) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccI6Z-0004Q5-OD for emacs-devel@gnu.org; Fri, 10 Feb 2017 15:47:43 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 858FD1600C3; Fri, 10 Feb 2017 12:47:40 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id T5ReoPFNvod5; Fri, 10 Feb 2017 12:47:39 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C46D81600D5; Fri, 10 Feb 2017 12:47:39 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2s-N9AAX1NMh; Fri, 10 Feb 2017 12:47:39 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AB0491600C3; Fri, 10 Feb 2017 12:47:39 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212215 Archived-At: On 02/10/2017 10:25 AM, Vibhav Pant wrote: > Are there any other issues before I merge this into master? For the C code, please use the usual style: space before paren in calls, GNU style indenting for curly braces, "/* " at start of comments, main operator like "||" at start of next line rather than at end of previous line. One of the 'if's is overparenthesized, i.e., "if ((E))" where E is an ordinary expression and "if (E)" will do. Prefer "if (BYTE_CODE_SAFE)" to "#ifdef BYTE_CODE_SAFE", as these days it's better to avoid the preprocessor when it's easy. This comment: /* Hash tables for switch are declared with :size set to the exact number of cases, thus HASH_TABLE_SIZE (h) == h->count. */ is something that could be checked, no? Perhaps replace the comment with "if (BYTE_CODE_SAFE) eassert (HASH_TABLE_SIZE (h) == h->count);" and do the latter even with large hash tables? If you change the loop from "for (i = 0; i < h->count; i++)" to "for (i = h->count; 0 <= --i; )", then you can merge the two copies of "op = XINT (HASH_VALUE (h, i)); goto ob_branch;" into one copy that is after the surrounding "if".