From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: Flymake refactored Date: Sun, 08 Oct 2017 10:06:15 +0100 Message-ID: <87376uxb3s.fsf@gmail.com> References: <87h8vmj3tr.fsf@lolita> <1507138648.1972.0@smtp.gmail.com> <874lre2von.fsf@gmail.com> <87mv566yjx.fsf@udel.edu> <87shex276r.fsf@gmail.com> <87efqh2sud.fsf@udel.edu> <20171006151753.tmdunffovz7olhey@logos.localdomain> <87h8vbx7p3.fsf@gmail.com> <20171007181824.k6pf2ztgxyodmx4a@logos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1507453635 25041 195.159.176.226 (8 Oct 2017 09:07:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 09:07:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: emacs-devel@gnu.org, Simen =?utf-8?Q?Heggest=C3=B8yl?= , dgutov@yandex.ru, Steve Purcell , sdl.web@gmail.com, monnier@iro.umontreal.ca To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 08 11:07:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e17YD-0005k4-J1 for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 11:07:09 +0200 Original-Received: from localhost ([::1]:52977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e17YJ-0007CB-4P for ged-emacs-devel@m.gmane.org; Sun, 08 Oct 2017 05:07:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e17XZ-0007Bu-Bl for emacs-devel@gnu.org; Sun, 08 Oct 2017 05:06:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e17XU-0007qV-DM for emacs-devel@gnu.org; Sun, 08 Oct 2017 05:06:29 -0400 Original-Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:47009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e17XU-0007q7-6v for emacs-devel@gnu.org; Sun, 08 Oct 2017 05:06:24 -0400 Original-Received: by mail-wm0-x233.google.com with SMTP id m72so15648194wmc.1 for ; Sun, 08 Oct 2017 02:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bfeCBDkCnwMfEI3BlTipoZF94eNVs/TPJ+hAHfTHZm8=; b=f40tJ2FmSoYk+qvSccX/nreLj0R27ZtTcwtVl2PHtXEl2WLKegwYRuCvNKvsc/XiUs JErz7KkrJBZMb8iALK+O93B3nRQJxblMKLxS9UoaVH5jf4APScEv8Pc9d7VAxfdG3cK8 d2pv0UCOndKTAAzYbJiJ+HDpHdhDk9QoKJYOlWeDMD1rY/F8TvYM2WloDPMjWxZlq885 mZ+o94RmjaiUJYlrnRoOlBxe04+gigouPRRrRlG9Lcu85/nyy6kfWG0WLkAFO44WZ/N4 8GkpzEj7JESdWHYoO4V3R/NJRjFdJIST5TtB8mC6s/EHWrdI4hISvkl8Z1BKfIHzf+38 X7Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bfeCBDkCnwMfEI3BlTipoZF94eNVs/TPJ+hAHfTHZm8=; b=gkQY15GYy0sdEyQMnh8+Qc8RKXvUdV7faEoMpE/XACr55n4yhmnEe/QusOpTKWfiv9 zTVAOb8qaq0sxBJFDbkVIPP9u23tMrAQ0ex+kR6D0128KE4q0THtxllO5CnNn+yECk1o 3tec5oZiC0ueqpBzmcB6SfHOyLsPRpiCwckAe/C+ajlYCxlxnevfEs4iH02F6UCS4aQJ 1y/+CP1RaSSdjzxtlZ3ecL1MEnMG7fv9Iy9M9RKC9t3p1GaPs7Jno3hTcF3QoDou96Cu H9+ezHzace3okAPMgWz9Cj8cWtwtAjattyzmxltkW3D6IyoMbHziiqok+Kwmb5Fdgooi 6deg== X-Gm-Message-State: AMCzsaVPeseuoIpFEjEHKtJ54z8ZUY6Wxi1dxfcZIqz82oo2rpt0S6/1 4pM1e3pJKTa3Vb7Dwt3d/qo= X-Google-Smtp-Source: AOwi7QASu3t4j5NCaBK/KAAK9O2H7jfV/9AC6c0nu00v0qps66dyv1OYk2GOEW7RQyeRQQDY6f1Hmw== X-Received: by 10.28.132.141 with SMTP id g135mr5143269wmd.37.1507453582903; Sun, 08 Oct 2017 02:06:22 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id 92sm2168737wrd.15.2017.10.08.02.06.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Oct 2017 02:06:22 -0700 (PDT) In-Reply-To: <20171007181824.k6pf2ztgxyodmx4a@logos.localdomain> (Mark Oteiza's message of "Sat, 7 Oct 2017 14:18:24 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219240 Archived-At: Mark Oteiza writes: > On 07/10/17 at 05:07pm, Jo=C3=A3o T=C3=A1vora wrote: >> Mark Oteiza writes: >>=20 >> > Sure, I've been reading flycheck and syntastic (analogous package for >> > vim) for reference. >> > >> > There are some things aside from checkers I think flymake should learn >> > from flycheck--may as well list some here: >> > [...] >> > - popup a special buffer with all the error/warning/info listed >>=20 >> Please have a look at the scratch/flymake-diagnostics-buffer branch and >> tell me what you think (perhaps comparing it to Flycheck's). The command >> is flymake-show-diagnostics-buffer. >>=20 >> It's very naively implemented for now (and seems kinda slow). > > Looks good, I'd just change from using buttons to having the whole line > be usable to navigate to the error. Agree, makes sense. But this seems akward to do in tabulated-list-mode. I don't mind if you beat me to it :-) > Perhaps the biggest thing is doing > like M-x grep and being able to M-g M-{n,p} and follow in the code > buffer, but I suspect that ties into the next-error issue. Yes, I believe this can of worms has to be opened eventually. > I suspect it's the use of overlays making it slow--I don't think you > need overlays at all for this--just store what you need in the > tabulated-list id which IIRC gets applied to the whole line as a text > property, which you can then use with (tabulated-list-get-id) But it doesn't make any new overlays, if that was your idea. The overlays used are the ones in the source buffer, where they can hardly be avoided. Using them here seemed like the easiest and fastest way to get to all Flymake diagnostics in a buffer. I might have exaggerated the performance hit, since it doesn't seem so slow to me now. Perhaps we could get some big files full of errors and run some benchmarks with a proper backend that can be found in Flycheck, too. Jo=C3=A3o