From: Robert Cochran <robert+Emacs@cochranmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/
Date: Wed, 21 Feb 2018 19:05:11 -0800 [thread overview]
Message-ID: <87371tn2qg.fsf@cochranmail.com> (raw)
In-Reply-To: <jwvfu5u5etk.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Wed, 21 Feb 2018 14:24:29 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Now that the byte-compile-error-on-warn patch was merged (thanks by the
>> way!), this is the next step: I've marked most every file in lisp/
>> that currently byte-compiles without warnings with
>> 'byte-compile-error-on-warn: t' in its file local variables.
>
> I sometimes consider it preferable to keep a warning than to silence it
> (typically because I can't fix it (yet)). This said, I'm fine with
> adding such annotations for those files which currently don't have warnings.
Yeah, right now it is only marking files that emit no warnings
whatsoever. I intend for this to be a situation similar to
lexical-binding, where it is enabled on a per file as they get cleaned
up and become warning-free.
I am trying to keep warnings from lingering. The
string-{to,as}-{multi,uni}byte family of functions have been deprecated
since June 2016, which are some of the functions I see the most in the
deprecation warnings. Stuff like that.
>> So, it's my understanding that there are some portions of what's in
>> emacs.git - org-mode being the prominent example in my mind - are simply
>> merges of a separate repository into emacs.git.
>
> You'll want to be super extra careful with files that are also
> distributed outside of Emacs, since they may emit warnings when compiled
> by a different version of Emacs (typically one that doesn't exist yet).
Hmm, sounds like its better to just not do that with files distributed
in parallel. I don't have a problem with that (most files is better than
no files after all), but I have no idea which ones are and are not 'core
only' files. Guidance requested.
Thanks,
--
~Robert Cochran
GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE E7B9 EC9A 872C 41B2 77C2
next prev parent reply other threads:[~2018-02-22 3:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:30 [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Robert Cochran
2018-02-21 18:42 ` Eli Zaretskii
2018-02-22 2:51 ` Robert Cochran
2018-02-22 6:56 ` Eli Zaretskii
2018-02-21 19:24 ` Stefan Monnier
2018-02-22 3:05 ` Robert Cochran [this message]
2018-02-22 5:24 ` Stefan Monnier
2018-02-22 7:18 ` Eli Zaretskii
2018-02-23 9:47 ` Richard Stallman
2018-02-24 11:08 ` Eli Zaretskii
2018-02-24 23:33 ` Richard Stallman
2018-02-25 3:33 ` Eli Zaretskii
2018-02-25 13:13 ` Stefan Monnier
2018-02-25 15:33 ` Eli Zaretskii
2018-02-22 7:13 ` Eli Zaretskii
2018-02-21 19:26 ` Noam Postavsky
2018-02-22 2:29 ` Robert Cochran
2018-02-22 3:24 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87371tn2qg.fsf@cochranmail.com \
--to=robert+emacs@cochranmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).