* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
[not found] ` <20180727093405.6D4D521616@vcs0.savannah.gnu.org>
@ 2018-07-29 10:16 ` Robert Pluim
2018-07-29 13:56 ` Paul Eggert
2018-07-29 14:46 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Robert Pluim @ 2018-07-29 10:16 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
eliz@gnu.org (Eli Zaretskii) writes:
> @@ -288,13 +289,15 @@ char_width (int c, struct Lisp_Char_Table *dp)
> if (VECTORP (disp))
> for (i = 0, width = 0; i < ASIZE (disp); i++)
> {
> + int c;
> ch = AREF (disp, i);
> - if (CHARACTERP (ch))
> - {
> - int w = CHARACTER_WIDTH (XFASTINT (ch));
> - if (INT_ADD_WRAPV (width, w, &width))
> - string_overflow ();
> - }
> + if (GLYPH_CODE_P (ch))
> + c = GLYPH_CODE_CHAR (ch);
> + else if (CHARACTERP (ch))
> + c = XFASTINT (ch);
> + int w = CHARACTER_WIDTH (c);
> + if (INT_ADD_WRAPV (width, w, &width))
> + string_overflow ();
> }
> }
> return width;
With gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)
this gives me the following warning:
In file included from character.c:34:0:
character.c: In function ‘char_width’:
lisp.h:1772:11: warning: ‘c’ may be used uninitialized in this function [-Wmaybe-uninitialized]
? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \
^
character.c:292:10: note: ‘c’ was declared here
int c;
^
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
2018-07-29 10:16 ` emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276) Robert Pluim
@ 2018-07-29 13:56 ` Paul Eggert
2018-07-30 7:07 ` Robert Pluim
2018-07-29 14:46 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Paul Eggert @ 2018-07-29 13:56 UTC (permalink / raw)
To: Robert Pluim, emacs-devel; +Cc: Eli Zaretskii
Does the patch cited below fix things for you?
https://debbugs.gnu.org/32276#13
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
2018-07-29 10:16 ` emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276) Robert Pluim
2018-07-29 13:56 ` Paul Eggert
@ 2018-07-29 14:46 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2018-07-29 14:46 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sun, 29 Jul 2018 12:16:22 +0200
>
> With gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)
> this gives me the following warning:
>
> In file included from character.c:34:0:
> character.c: In function ‘char_width’:
> lisp.h:1772:11: warning: ‘c’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \
> ^
> character.c:292:10: note: ‘c’ was declared here
> int c;
> ^
Yes, sorry about my omission. Should be fixed now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
2018-07-29 13:56 ` Paul Eggert
@ 2018-07-30 7:07 ` Robert Pluim
2018-07-30 14:21 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Robert Pluim @ 2018-07-30 7:07 UTC (permalink / raw)
To: Paul Eggert; +Cc: Eli Zaretskii, emacs-devel
Paul Eggert <eggert@cs.ucla.edu> writes:
> Does the patch cited below fix things for you?
>
> https://debbugs.gnu.org/32276#13
Yes. Whichever order I read emacs-devel and emacs-bugs in, itʼs always
the wrong one :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
2018-07-30 7:07 ` Robert Pluim
@ 2018-07-30 14:21 ` Eli Zaretskii
2018-07-30 14:44 ` Robert Pluim
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2018-07-30 14:21 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 30 Jul 2018 09:07:21 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
> > Does the patch cited below fix things for you?
> >
> > https://debbugs.gnu.org/32276#13
>
> Yes. Whichever order I read emacs-devel and emacs-bugs in, itʼs always
> the wrong one :-)
You are saying that these lists behave like elementary particles, with
the associated quantum effects?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276)
2018-07-30 14:21 ` Eli Zaretskii
@ 2018-07-30 14:44 ` Robert Pluim
0 siblings, 0 replies; 6+ messages in thread
From: Robert Pluim @ 2018-07-30 14:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 30 Jul 2018 09:07:21 +0200
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>>
>> Paul Eggert <eggert@cs.ucla.edu> writes:
>>
>> > Does the patch cited below fix things for you?
>> >
>> > https://debbugs.gnu.org/32276#13
>>
>> Yes. Whichever order I read emacs-devel and emacs-bugs in, itʼs always
>> the wrong one :-)
>
> You are saying that these lists behave like elementary particles, with
> the associated quantum effects?
The more accurately I know what's being discussed on emacs-devel, the
less knowledge I have of the state of emacs-bugs (and vice-versa), so
yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-30 14:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180727093403.18242.35476@vcs0.savannah.gnu.org>
[not found] ` <20180727093405.6D4D521616@vcs0.savannah.gnu.org>
2018-07-29 10:16 ` emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276) Robert Pluim
2018-07-29 13:56 ` Paul Eggert
2018-07-30 7:07 ` Robert Pluim
2018-07-30 14:21 ` Eli Zaretskii
2018-07-30 14:44 ` Robert Pluim
2018-07-29 14:46 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).