From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 06 Nov 2018 02:04:58 +0100 Message-ID: <8736sfqamd.fsf@web.de> References: <20151216202605.GA3752@acm.fritz.box> <87pnw037ar.fsf@web.de> <83ftwvs7y9.fsf@gnu.org> <877ei7mkfh.fsf@web.de> <87a7mze7tl.fsf@web.de> <831s89mo03.fsf@gnu.org> <87pnvsifxt.fsf@web.de> <83muqwkkt1.fsf@gnu.org> <875zxjv3ku.fsf@web.de> <83o9bbjqcj.fsf@gnu.org> <87r2g7t7bo.fsf@web.de> <83tvl2hzt6.fsf@gnu.org> <87r2g5x3gk.fsf@web.de> <87va5gzxyk.fsf@web.de> <87lg6czxo9.fsf@web.de> <87y3a8jo2r.fsf@web.de> <83tvkvcxve.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541466787 4299 195.159.176.226 (6 Nov 2018 01:13:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 01:13:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: npostavs@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 06 02:13:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJpvS-0000yF-5x for ged-emacs-devel@m.gmane.org; Tue, 06 Nov 2018 02:13:02 +0100 Original-Received: from localhost ([::1]:38346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJpxY-0004CO-FX for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2018 20:15:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJpwN-0003xq-Lh for emacs-devel@gnu.org; Mon, 05 Nov 2018 20:14:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJpoK-0006fu-At for emacs-devel@gnu.org; Mon, 05 Nov 2018 20:05:43 -0500 Original-Received: from mout.web.de ([212.227.17.12]:40491) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJpns-0005zT-W7; Mon, 05 Nov 2018 20:05:16 -0500 Original-Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LgHLE-1fhBaC0dL2-00ngms; Tue, 06 Nov 2018 02:05:00 +0100 Original-Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LgHLE-1fhBaC0dL2-00ngms; Tue, 06 Nov 2018 02:05:00 +0100 In-Reply-To: <83tvkvcxve.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Nov 2018 18:06:29 +0200") X-Provags-ID: V03:K1:jKsGaJ1J88Q1PHSjuXjM9zhiSwqm02GUn8WWXXJtEOkrRYGoAr2 PimNJzlNL4LNaF8U7Jem3wsWUOJ8kmD/1iqsTBKYDi2lfF+NTck9IojLNBHkZ4EUXV96Tr7 YHyCkdxw7F3Xa2eDFisJyf1hy7MwF15P58M4FUHWwyhhCeAu5aY8BUpUZcy5pFW5XTdqT/s +ik6s1AYD6GiukfLpBH8A== X-UI-Out-Filterresults: notjunk:1;V01:K0:uiDlT7TjHls=:NbLKU6/8ZxuW7ILq09l1FV 6QsFMPZKW+EozWFhCBINQW0j4f3V5AIzYwHAQCAeNNWopO9g7j3R0IxKJ/D64wOXE1JP7jOTJ gl5OgEkEb9/uc2OzTatDp0QOXT1qYkQ+u/R3XqsOlmCQBDAuV+NB4atFGrYOwipyDwAaxL3QL kWv1AsE7+1dnWs8x6zzgJ8vFeeqvgfkHx3VhEUF0XNvxWjAyJRwoVOSZBohXPxg7P08h4tYAq wIrS264oqh5EIMOxjkaT1bgbgqNierU93dpjuT6s3QADh8nm/JnLHu6+XsgraWyHn+8Ob5Vqw Dc2Cp45qGpw8+Yn1mT1mcoBnpC1GRP5qFwdZ4VMaL6SoboXOP71evsg9EEJjIwRhGg9SRxHD1 k9V6i1FG31J6aomhauLBuWLP4vqkxzON5nJUSoUgQZV88z6iE4HxjEwXIPjhsBQ8pT+eg6LE0 OhzlCEz2t1EeqQcbqLKKBOShpjK9x81PEDWtxYrOsoTPVYrH6MgWECycob71DD33TRuwarco0 m/b9eogULoDVsu8q6k3RBTuYZGJmwlMyTKniXPX3Uza/xuk0XvsXnIOkgMeAwj1YoLI4MKJv9 mSKeAuW896IDH9wuV+54EkY+6DihQv47r5ClpwR1EK3imb8q3daQNqraDJcCvPyApno6wCXmV cUB4XNs8y5Z61VZw9wIOtBncCKvwUzQFVZS5SrERzmaHGcaTI+KeYwUtSEUkWwUTgOg9Z1mlx DH35GywbT8YdD8zeLOac6GNwZ/DQaq5h+7dKPUyNy2AWwUwTyH01dR5DRJFYdX5LYMP5dBxR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231033 Archived-At: Eli Zaretskii writes: > I obviously didn't proofread all of the changes, but what I did looked > good. Thanks. I'll wait some more days to see whether there are more comments. BTW, I think I'll revert the apparent fix in diff --git a/lisp/calendar/time-date.el b/lisp/calendar/time-date.el index c3898e0257..bb54ad46e3 100644 --- a/lisp/calendar/time-date.el +++ b/lisp/calendar/time-date.el @@ -109,7 +109,7 @@ with-decoded-time-value ,(append `(setq ,pico 0) (when type `(,type 2))))) (type - `(setq type 2)))) + `(setq ,type 2)))) ,(append `(setq ,micro 0) (when pico `(,pico 0)) (when type `(,type 1))))) The affected macro 'with-decoded-time-value' has been obsolete since 25.1, so I would prefer to just leave it as is. It's not used anywhere in Emacs. Michael.