From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant Date: Sun, 03 Mar 2019 02:06:28 +0000 Message-ID: <8736o47luj.fsf@tcd.ie> References: <20190302211432.19529.56286@vcs0.savannah.gnu.org> <20190302211434.9F9B6203C0@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71410"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 03 03:07:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h0GX9-000IOt-OM for ged-emacs-devel@m.gmane.org; Sun, 03 Mar 2019 03:07:19 +0100 Original-Received: from localhost ([127.0.0.1]:33044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0GX8-0005h1-Nx for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 21:07:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0GWR-0005gi-Li for emacs-devel@gnu.org; Sat, 02 Mar 2019 21:06:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0GWQ-0000hD-Th for emacs-devel@gnu.org; Sat, 02 Mar 2019 21:06:35 -0500 Original-Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:44297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0GWQ-0000b8-I3 for emacs-devel@gnu.org; Sat, 02 Mar 2019 21:06:34 -0500 Original-Received: by mail-ed1-x543.google.com with SMTP id b20so1421025edw.11 for ; Sat, 02 Mar 2019 18:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Ly5FbyA2XGSnamj9zrpdrY0ECZoNPBtyqDmI1nGJj1o=; b=BWNHmvf+e/BuTikZ7FLQXFlcMaHdhth0BQfbUvNKpaI04+0Rjb+k7p/zWLOI0abOo4 9c4PITo2emRq094l3jdOzxWdN/d0FglE19PCRUHxi+Dg7HymZXCurtd+mTquxUJwGxSr d3C4sIpubJ5pOmq+mJ3Wwsa7o/AoXHhyW6fWERnm/qW6nizz2yqVInflM4JYUr8oVsQu ZvuWINnmlA2Q9YFZOpD9zVihRuknOfZJDwVBfJqTiJD3K0OXmDB6pwFIPfoIO4JVZxFk fQEON6CHXtBSQ7Td23K/MT/00/iAy0lzpuzp8r9/KYjbQkVvzXVBfE3DS+jCYmarv90x 1EPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Ly5FbyA2XGSnamj9zrpdrY0ECZoNPBtyqDmI1nGJj1o=; b=G2h58ioF1viDg0nG1sSDmwSLwz5jeTSMVKsh5qgyEs+SUXndZvEMTQ8ipauknYOM2B Oc/qHQ2CEYjbQu+mes3EPkr7zSdacep4iEd3eP4TeY3ky/ON1GV7oZ0nsbTlXDQ0ebAc 4zc3mrfP7qv8cKl3quvfExLkXrb1RDP6HqVhCLkFsqlRcxsY+OT941B2bhHMkot1/VrW Imj4nlXLi4rPNKxr/uiZNwO8nYAAwB69nx2rx2rusznwW5NcQpJQmba0s6wENb04YhDS zMI5ll5Qwz8smUpMQkpfW9M6Ngcnay4zfvwIwhwUKbTaVL2ZDvG9Vnpiod1bCmxqdm8b ZeYg== X-Gm-Message-State: APjAAAV1m9iAHh7+S6nr+fxbH5TGqxyyoY90KSfSIP6N9eUnJDRLvfn0 cHQdPJ+664sEr3a3NenjRvN8xPqL9is= X-Google-Smtp-Source: APXvYqxcCcSsdV1uQW7vtKASjX/r5HUge4S8X0tNzoznjOmupN68h6LHGpWmJPZ8IFZi/aUMdCXbYQ== X-Received: by 2002:a50:b16e:: with SMTP id l43mr9497842edd.99.1551578790994; Sat, 02 Mar 2019 18:06:30 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id u15sm418366ejz.19.2019.03.02.18.06.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 02 Mar 2019 18:06:30 -0800 (PST) In-Reply-To: <20190302211434.9F9B6203C0@vcs0.savannah.gnu.org> (Paul Eggert's message of "Sat, 2 Mar 2019 16:14:32 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::543 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233784 Archived-At: eggert@cs.ucla.edu (Paul Eggert) writes: > branch: master > commit 284f635da833d2dbf0102af3442197b46adf78c5 > Author: Paul Eggert > Commit: Paul Eggert > > memory_full_cons_threshold is a constant >=20=20=20=20=20 > * src/alloc.c (memory_full_cons_threshold): Now const. > (memory_full): Omit no-longer-needed initialization. > --- > src/alloc.c | 12 ++++-------- > src/lisp.h | 2 +- > 2 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/src/alloc.c b/src/alloc.c > index 452d31f..9b3dc4b 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -234,7 +234,7 @@ byte_ct gc_relative_threshold; > /* Minimum number of bytes of consing since GC before next GC, > when memory is full. */ >=20=20 > -byte_ct memory_full_cons_threshold; > +byte_ct const memory_full_cons_threshold =3D sizeof (struct cons_block); struct cons_block doesn't seem to be defined yet, because I get the following error with gcc 8.2.0: CC alloc.o alloc.c:237:52: error: invalid application of =E2=80=98sizeof=E2=80=99 to i= ncomplete type =E2=80=98struct cons_block=E2=80=99 byte_ct const memory_full_cons_threshold =3D sizeof (struct cons_block); --=20 Basil