Re: [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant

Re: [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant

[Basil L. Contovounesios]

eggert@cs.ucla.edu (Paul Eggert) writes:

> branch: master
> commit 284f635da833d2dbf0102af3442197b46adf78c5
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
>     memory_full_cons_threshold is a constant
>     
>     * src/alloc.c (memory_full_cons_threshold): Now const.
>     (memory_full): Omit no-longer-needed initialization.
> ---
>  src/alloc.c | 12 ++++--------
>  src/lisp.h  |  2 +-
>  2 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/src/alloc.c b/src/alloc.c
> index 452d31f..9b3dc4b 100644
> --- a/src/alloc.c
> +++ b/src/alloc.c
> @@ -234,7 +234,7 @@ byte_ct gc_relative_threshold;
>  /* Minimum number of bytes of consing since GC before next GC,
>     when memory is full.  */
>  
> -byte_ct memory_full_cons_threshold;
> +byte_ct const memory_full_cons_threshold = sizeof (struct cons_block);

struct cons_block doesn't seem to be defined yet, because I get the
following error with gcc 8.2.0:

  CC       alloc.o
alloc.c:237:52: error: invalid application of ‘sizeof’ to incomplete type ‘struct cons_block’
 byte_ct const memory_full_cons_threshold = sizeof (struct cons_block);

-- 
Basil

Re: [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant

[Paul Eggert]

Basil L. Contovounesios wrote:
> struct cons_block doesn't seem to be defined yet

Thanks for reporting that. Evidently I installed the wrong version. I installed 
a patch.