From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: emacs-devel@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant
Date: Sun, 03 Mar 2019 02:06:28 +0000 [thread overview]
Message-ID: <8736o47luj.fsf@tcd.ie> (raw)
In-Reply-To: <20190302211434.9F9B6203C0@vcs0.savannah.gnu.org> (Paul Eggert's message of "Sat, 2 Mar 2019 16:14:32 -0500 (EST)")
eggert@cs.ucla.edu (Paul Eggert) writes:
> branch: master
> commit 284f635da833d2dbf0102af3442197b46adf78c5
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
> memory_full_cons_threshold is a constant
>
> * src/alloc.c (memory_full_cons_threshold): Now const.
> (memory_full): Omit no-longer-needed initialization.
> ---
> src/alloc.c | 12 ++++--------
> src/lisp.h | 2 +-
> 2 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/src/alloc.c b/src/alloc.c
> index 452d31f..9b3dc4b 100644
> --- a/src/alloc.c
> +++ b/src/alloc.c
> @@ -234,7 +234,7 @@ byte_ct gc_relative_threshold;
> /* Minimum number of bytes of consing since GC before next GC,
> when memory is full. */
>
> -byte_ct memory_full_cons_threshold;
> +byte_ct const memory_full_cons_threshold = sizeof (struct cons_block);
struct cons_block doesn't seem to be defined yet, because I get the
following error with gcc 8.2.0:
CC alloc.o
alloc.c:237:52: error: invalid application of ‘sizeof’ to incomplete type ‘struct cons_block’
byte_ct const memory_full_cons_threshold = sizeof (struct cons_block);
--
Basil
next parent reply other threads:[~2019-03-03 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190302211432.19529.56286@vcs0.savannah.gnu.org>
[not found] ` <20190302211434.9F9B6203C0@vcs0.savannah.gnu.org>
2019-03-03 2:06 ` Basil L. Contovounesios [this message]
2019-03-03 7:03 ` [Emacs-diffs] master 284f635: memory_full_cons_threshold is a constant Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736o47luj.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).