From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to text-mode.el Date: Wed, 27 Mar 2019 03:50:26 +0000 Message-ID: <8736n9vuv1.fsf@tcd.ie> References: <87o95yxvtt.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183323"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 05:02:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8zla-000lYe-F9 for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 05:02:18 +0100 Original-Received: from localhost ([127.0.0.1]:41559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8zlZ-0006Ob-EW for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 00:02:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8zlP-0006E8-Es for emacs-devel@gnu.org; Wed, 27 Mar 2019 00:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8zaA-0000ew-7v for emacs-devel@gnu.org; Tue, 26 Mar 2019 23:50:31 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:33214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8zaA-0000eE-04 for emacs-devel@gnu.org; Tue, 26 Mar 2019 23:50:30 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id q3so12743077edg.0 for ; Tue, 26 Mar 2019 20:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6azge0glqOMSJoj+RT+92DTWtmdk7fekkeb0AVNQt1M=; b=NMzL9MshHFZyuGVP+iW+svClFmnOQ8FCWaVtWbhx8r/Hq2ZHsTxeo3Eq0jhy/YdcM/ 4nWZLqDTsuDFZlWvSW0h5Eob/Qo6Il75rx/se1fs2jwgTxUiZRrnPal0dvTfIBVO7JlI VEp9qIbjQNtB1Cbfu7187D6VhRpEqtPfl5EaDs0MGqOSAnn+bc9iHVP+U19YQSWDwHj8 fuZgZKD3sKJPZFhdFXr0UXJDcJG1ZQTb+xfHyZt+iCBI4sk9aY3EJG0mf4/992rJ4L37 stAlSq1WBYGg/9NN/4J7rshMVQfUxfQIxwS36vwwh00Voff7ymIv4k48gUzt+5koMpMW /wKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6azge0glqOMSJoj+RT+92DTWtmdk7fekkeb0AVNQt1M=; b=fG9meJLevFgVMZPqPXre/Sl/g8HZu3w4mIt3xGBko+HohDpYk5UHq/C0LuLezHnT60 9D6Z7JL/1ftPOaz8zyH7R/0xgBaefAxQLAHmLY1turSiLgLNkEwigl8Crjn0e64IRQdF Q0bQCc9rM/lLjan1zTJ1GsXsbsu39Ech216ObwHZSXa7SqpMyYKF60JGK6BraXqUlFNP u0E34KODyFVn59psbM3jHY0K1OyUw0zQOkYuILJ/oAXOoy6w6UM5PPSdICqvV5d9AZMS MnadtrDEhf4uJubKLpNuIDotQl2IoLpOt8Usy8p6evOg+6UmxJ8U7fBLD6EK816VEPJd Oc1w== X-Gm-Message-State: APjAAAXE8gcb2kf5ZisCeUIgmpk9YL8zBUijQeiYDbjNhXE1M1S7vrKO gdOFgHglQUzQ7SjnVF3CRUnJ8Q== X-Google-Smtp-Source: APXvYqxIX9tc1sk2TT1zqRhtEpV9ZHsS7/cUDlxKS214xjwGNhjv1bfjSZBnXhiECEkup1iOFPQWsA== X-Received: by 2002:a17:906:4bc3:: with SMTP id x3mr17474434ejv.150.1553658628524; Tue, 26 Mar 2019 20:50:28 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id 21sm4415744ejj.75.2019.03.26.20.50.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 26 Mar 2019 20:50:27 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 26 Mar 2019 09:00:34 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::535 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234762 Archived-At: Stefan Monnier writes: >> I attach three patches for lisp/textmodes/text-mode.el arising from the >> discussion in bug#34671. >> >> The first enables lexical-binding and makes some minor simplifications. >> >> The second makes text-mode no longer reset indent-line-function to >> indent-relative locally, a change (info "(elisp) Example Major Modes") >> has been promising for many moons. AFAICT, text-mode works even when >> indent-line-function is not set to indent-relative (as I'd hope). I've >> had a quick look through all the modes derived from text-mode in >> emacs.git and nothing strikes me as an obvious incompatibility with the >> proposed change. Are there any significant reasons to keep the current >> setting of indent-line-function in text-mode? > > The reason why I kept the `setq-local` when I changed the default to > `indent-relative` was simply to be conservative. > >> The third obsoletes the variable text-mode-variant, which is unused in >> both emacs.git and elpa.git, and has been recommending derived-mode-p as >> a better alternative in its docstring for almost two decades. >> WDYT? > > LGTM, Thanks for the clarification and review. I'll wait a few more days for others to comment before pushing. -- Basil