From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Increase minimum required GTK versions? Date: Fri, 12 Apr 2019 13:05:30 -0600 Message-ID: <8736mnvybp.fsf@gmail.com> References: <87h8b9tz84.fsf@gmail.com> <83h8b98wg3.fsf@gnu.org> <87d0lxty7f.fsf@gmail.com> <537036b7-549c-0aab-cc06-70c26c683ac7@cs.ucla.edu> <87y34kiloy.fsf@gmail.com> <87o95f141i.fsf@gmail.com> <838swj6nuk.fsf@gnu.org> <87h8b61rid.fsf@gmail.com> <83sgup6ef8.fsf@gnu.org> <87tvf5tm4f.fsf@gmail.com> <83r2a7kqi6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203432"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 12 21:06:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hF1VT-000qny-65 for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 21:06:35 +0200 Original-Received: from localhost ([127.0.0.1]:41491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1VS-00062P-5t for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 15:06:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1Ub-00060N-VV for emacs-devel@gnu.org; Fri, 12 Apr 2019 15:05:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hF1Ua-0005rM-OG for emacs-devel@gnu.org; Fri, 12 Apr 2019 15:05:41 -0400 Original-Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:39355) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hF1Ua-0005qx-G8; Fri, 12 Apr 2019 15:05:40 -0400 Original-Received: by mail-pf1-x42f.google.com with SMTP id i17so5577979pfo.6; Fri, 12 Apr 2019 12:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XLf8c5HwMIJwjJ2xvQkAr3STrF0XjTTbJkt7osEEE28=; b=DkOqHJEUTsMBH297bWcVqpC27Wt7R+/0dqroeNXb5vq66Ws59xQkdmv4h+sWUr/wM6 5vfr+qcLm8rRslVMI22fHhrJV8IcqqGeWcp8UFVLT2pSuytFHBmrdFoyhMf0fg6m8CYR Bxr7UHWqixgmDDT89WiwIu/Le5jyZJ9mnoG+VIYr3R/1gDgNxKwwvTPSiPojaa6nWh7y v98qH/bBCGVPDyC92L9Ji3bZZr5SoYMFM0PaLshkHOtRo7LkgEVkR4O9cuB6m8MSW7J9 gYokkcs8MZd1Nr5gfpU2p+MsSZRsTHnHJ/QMlrVeeQuZndIKXgU+P3h4DtZMVPKvpr4V +5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XLf8c5HwMIJwjJ2xvQkAr3STrF0XjTTbJkt7osEEE28=; b=Y7kvzPwbgBCKaOnEk55OZffB3U/tCzcrGnykJsLec9Chomfi3uF8eD0icHiwktQ3fQ TAQogALYQp52pIGLWJ19xKkMaSF5HZNw/pa8Y3jv25Zphh2JRDCOso+0cpaDigWFcNuV HSYgjMgjH701Nl7mrS39rMwLrj/+fiKcTjurRV4ZgpEFaVzdQC9QqaXGyLB9gBxmTkYH tjcSuceUqa5koAuW/fzfPDGrZcCnzkXj7Kc/46W4KR6UoQxBNWNQ2Qyp4+3pln6Walz7 r9KbinNO1PGyX9q2REUueJUClX6B7trISs7afY+uU62mRurEU5O7NEHyl9MnMU/vnaQ8 EfRA== X-Gm-Message-State: APjAAAUaPyYuuU4f2WufOUdJCs8q52qA3+HpjMQNV1QXFNzFvYO4U1ys DjD1kvKrydoOni+WeB2f4tw3YsYg X-Google-Smtp-Source: APXvYqwz7a9HDrM6JndWiA7AzchhnX+g9fjypIiN4PZ5FAQdCZAsUZsQxDzHMOl3h6OWHLQWf1fVgw== X-Received: by 2002:a63:e10b:: with SMTP id z11mr54549131pgh.46.1555095939081; Fri, 12 Apr 2019 12:05:39 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id 66sm84451550pfr.44.2019.04.12.12.05.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 12:05:38 -0700 (PDT) In-Reply-To: <83r2a7kqi6.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Apr 2019 21:49:54 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235363 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Wed, 10 Apr 2019 18:35:12 -0600 >> >> >> * Old file selection dialog >> >> This is only optionally used in GTK 2, but the old dialog is long >> >> deprecated in GTK 2 (removed in GTK 3), so I figured that this is a good >> >> time to remove it and simplify the existing code. >> > >> > I think this should be left alone. It's a separate issue anyway, and >> > should be submitted separately. It would be good to try to establish >> > whether this feature is turned on by someone, but given that it's only >> > for GTK2, I tend to think we should simply let it die a natural death >> > together with GTK2. >> >> Okay, done. > > Are you sure? I still see the code related to this being removed. That's part of the simplification of the code. Before it uses a predicate procedure to check the value of x_gtk_use_old_file_dialog, which I removed in favour of checking the variable directly. It also used function pointers to wrapper procedures to get the filename, which I removed in favour of calling the gtk procedures directly. The actual old file dialog (xg_get_file_with_selection) is, in this patch, still present. I tested again with GTK 2.24 and GTK 3.10 and it worked as expected. Are you okay with this part of the change?