* commit 8147d3c27c breaks grep over tramp
@ 2019-04-09 14:28 John Shahid
2019-04-09 15:02 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: John Shahid @ 2019-04-09 14:28 UTC (permalink / raw)
To: Emacs developers
Hi all,
Looks like commit 8147d3c27c breaks `grep' when ran on a remote host
using tramp. Previous to the commit I would see the list of grep hits,
but after this commit there is a command prompt as part of the grep
hits. This makes the first hit unclickable. I bisected the history to
find the offending commit and found the following change to be the
cause:
> @@ -2912,8 +2903,7 @@ tramp-sh-handle-make-process
> ;; otherwise we might be interrupted by
> ;; `verify-visited-file-modtime'.
> (let ((buffer-undo-list t)
> - (inhibit-read-only t)
> - (mark (point-max)))
> + (inhibit-read-only t))
> (clear-visited-file-modtime)
> (narrow-to-region (point-max) (point-max))
> ;; We call `tramp-maybe-open-connection', in
> @@ -2926,9 +2916,7 @@ tramp-sh-handle-make-process
> (let ((pid (tramp-send-command-and-read v "echo $$")))
> (process-put p 'remote-pid pid)
> (tramp-set-connection-property p "remote-pid" pid))
> - (widen)
> - (delete-region mark (point-max))
> - (narrow-to-region (point-max) (point-max))
> + (delete-region (point-min) (point-max))
Is anyone else seeing the same thing or is it something with my
configuration ?
Cheers,
JS
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: commit 8147d3c27c breaks grep over tramp
2019-04-09 14:28 commit 8147d3c27c breaks grep over tramp John Shahid
@ 2019-04-09 15:02 ` Michael Albinus
2019-04-09 17:38 ` John Shahid
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2019-04-09 15:02 UTC (permalink / raw)
To: John Shahid; +Cc: Emacs developers
John Shahid <jvshahid@gmail.com> writes:
> Hi all,
Hi John,
> Looks like commit 8147d3c27c breaks `grep' when ran on a remote host
> using tramp. Previous to the commit I would see the list of grep hits,
> but after this commit there is a command prompt as part of the grep
> hits. This makes the first hit unclickable. I bisected the history to
> find the offending commit and found the following change to be the
> cause:
Will check. My respective commit message was
(tramp-sh-handle-make-process): Simplify.
Maybe this part of the patch could simply be withdrawn. I'm short in
time these days, so I cannot promise it will happen before the weekend,
but who knows ...
> Is anyone else seeing the same thing or is it something with my
> configuration ?
I do :-(
Obviously, tramp-tests.el must be extended, because they've passed
before I've committed the above patch.
> Cheers,
>
> JS
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: commit 8147d3c27c breaks grep over tramp
2019-04-09 15:02 ` Michael Albinus
@ 2019-04-09 17:38 ` John Shahid
2019-04-13 10:39 ` Michael Albinus
0 siblings, 1 reply; 5+ messages in thread
From: John Shahid @ 2019-04-09 17:38 UTC (permalink / raw)
To: Michael Albinus; +Cc: Emacs developers
[...]
> Maybe this part of the patch could simply be withdrawn. I'm short in
> time these days, so I cannot promise it will happen before the weekend,
> but who knows ...
Thanks for getting back to me. Take your time, I will revert this
change locally or use a previous commit for now.
>
>> Is anyone else seeing the same thing or is it something with my
>> configuration ?
>
> I do :-(
>
> Obviously, tramp-tests.el must be extended, because they've passed
> before I've committed the above patch.
I will take a look to see if I can add the missing test coverage.
Cheers,
JS
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: commit 8147d3c27c breaks grep over tramp
2019-04-09 17:38 ` John Shahid
@ 2019-04-13 10:39 ` Michael Albinus
2019-04-14 21:54 ` John Shahid
0 siblings, 1 reply; 5+ messages in thread
From: Michael Albinus @ 2019-04-13 10:39 UTC (permalink / raw)
To: John Shahid; +Cc: Emacs developers
John Shahid <jvshahid@gmail.com> writes:
Hi John,
>> Maybe this part of the patch could simply be withdrawn. I'm short in
>> time these days, so I cannot promise it will happen before the weekend,
>> but who knows ...
>
> Thanks for getting back to me. Take your time, I will revert this
> change locally or use a previous commit for now.
Should be fixed now in master. I've reverted the change in
tramp-sh-handle-make-process, and I've added a comment to stop me (and
other people) doing the same error, again.
> Cheers,
>
> JS
Best regards, Michael.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-14 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09 14:28 commit 8147d3c27c breaks grep over tramp John Shahid
2019-04-09 15:02 ` Michael Albinus
2019-04-09 17:38 ` John Shahid
2019-04-13 10:39 ` Michael Albinus
2019-04-14 21:54 ` John Shahid
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).