From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: [PATCH] * configure.ac: Avoid gnulib's test for pthread_sigmask Date: Thu, 02 May 2019 17:09:10 -0600 Message-ID: <8736lwmp2h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50632"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 01:09:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMKpZ-000D2R-Kn for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 01:09:33 +0200 Original-Received: from localhost ([127.0.0.1]:59668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMKpY-00061T-M3 for ged-emacs-devel@m.gmane.org; Thu, 02 May 2019 19:09:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMKpT-00061M-CG for emacs-devel@gnu.org; Thu, 02 May 2019 19:09:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMKpN-0007yL-Hb for emacs-devel@gnu.org; Thu, 02 May 2019 19:09:27 -0400 Original-Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:41055) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMKpN-0007t4-9p for emacs-devel@gnu.org; Thu, 02 May 2019 19:09:21 -0400 Original-Received: by mail-pg1-x532.google.com with SMTP id f6so1738417pgs.8 for ; Thu, 02 May 2019 16:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=eXlOt6x0D98Sh4jwDOfge7qvdOvgOfJsV8Ol9NrjNhY=; b=cjo9Ow0Q5+KZQUKXv5ss1T4JDSxnR1/NdG3OfYPDC3dnPuFlJGCMvpNziA4b3J8svh leFcMWxQwKUZOjfDXWDEjyo5iHoe8orH63jk0igKxArdA4CUm4llB5wA600T4WcjvgNL rhM+wLW131vJxB8KllQBEmuyZG2VBvC2oY2R81UK4x6rmjqyetoVsCI9B0DEdzDhZfbP nTkfWtyhai9Jp+hAZchHrkZYaJXyX7w+zISSRvPxju2EDb0LhHwNjPqaLzbw6hdzDrnF hwm/0u/Cbt1B5qXYDs4t0vmlRFUzSJaJDkY62XffRDIQzqgbTblOD2iwzp5BJBZWA4gB BDPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=eXlOt6x0D98Sh4jwDOfge7qvdOvgOfJsV8Ol9NrjNhY=; b=eAVp8m1lrhsVrxuE1hEix3Wij+3JxCVrAbY/t74c2Thfx25/uuS+rMj4s26qFCPqy4 TLVglQFlGuX+KBpxyJdA0P07URjEL7xfZ/xcimzeCdjA6fBcKUKiF4wXRfthJmvGN6d1 /XKvBOvlDpVLoe4cYZqLmz0Mkw1IJdMDXUyJFVAtE3pFPge9sGMkc4aEmFmT5jpZDeTE 5v4i3qH0D6hj6Dc2zDWDMDwhQ5Lx2EEqXoUFfnX7NZ+npWS9iNgQnpBoOq5DWgQ7XBHq qTdJFh+9WpB3yt1IEHqS8MN4EOw761fU2yOS+mYZTlOaKH82qZs8CTwh/KgFtRp7Feij Gn6g== X-Gm-Message-State: APjAAAUz8iPJn3+pA1K9ZCeB/DrvBech13SUORU0D/ZoFboGAwESapJm Bmppi+YrN428TjSZRSDqVtJ4UGXd X-Google-Smtp-Source: APXvYqx4+yyR5O3wREQ8m5bOoFrWSHU4t2cni22WHYbn9Zr3eFsb7IF1wfXrVXSrxn6YMvNaL2glxw== X-Received: by 2002:a63:e045:: with SMTP id n5mr6349929pgj.230.1556838557061; Thu, 02 May 2019 16:09:17 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id c127sm293931pfc.132.2019.05.02.16.09.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 16:09:16 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::532 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236101 Archived-At: --=-=-= Content-Type: text/plain The nearby comment states "Avoid gnulib's test for pthread_sigmask", but the method used doesn't seem to work. What I see is that gl_INIT is called, which calls gl_FUNC_PTHREAD_SIGMASK. The method in the attached patch is the same as used for avoiding other gnulib tests. If the test is really to be avoided, then I would think it to be better to remove m4/pthread_sigmask.m4 so that gl_INIT doesn't include the test in the first place. It doesn't look like any of the code uses the result of it. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-configure.ac-Avoid-gnulib-s-test-for-pthread_sigmask.patch Content-Description: pthread_sigmask avoidance >From a30ccae87d6f4f7d8cb0c061625e09c59c960052 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Thu, 2 May 2019 16:49:15 -0600 Subject: [PATCH] * configure.ac: Avoid gnulib's test for pthread_sigmask The previous method wasn't working correctly. --- configure.ac | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 79fe0c98c6..333da87aa5 100644 --- a/configure.ac +++ b/configure.ac @@ -876,11 +876,8 @@ AC_DEFUN # as we don't use them. AC_DEFUN([gl_FCNTL_O_FLAGS]) # Avoid gnulib's test for pthread_sigmask. -funcs= -for func in $ac_func_list; do - test $func = pthread_sigmask || AS_VAR_APPEND([funcs], [" $func"]) -done -ac_func_list=$funcs +AC_DEFUN([gl_FUNC_PTHREAD_SIGMASK]) + # Use the system putenv even if it lacks GNU features, as we don't need them, # and the gnulib replacement runs afoul of a FreeBSD 10.1 bug; see Bug#19874. AC_CHECK_FUNCS_ONCE([putenv]) -- 2.21.0 --=-=-=--