From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Image-conversion shims Date: Mon, 30 Sep 2019 06:12:03 +0200 Message-ID: <8736gea0do.fsf@gnus.org> References: <87v9tctcca.fsf@gnus.org> <87impct2xf.fsf@gnus.org> <83zhinfufb.fsf@gnu.org> <87ftkfnx7a.fsf@gnus.org> <83eezzfh8c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="230943"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 30 06:12:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEn2u-000xxY-1H for ged-emacs-devel@m.gmane.org; Mon, 30 Sep 2019 06:12:24 +0200 Original-Received: from localhost ([::1]:43512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEn2s-0001IU-Fv for ged-emacs-devel@m.gmane.org; Mon, 30 Sep 2019 00:12:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEn2l-0001IC-4J for emacs-devel@gnu.org; Mon, 30 Sep 2019 00:12:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEn2j-0007ZF-Uu for emacs-devel@gnu.org; Mon, 30 Sep 2019 00:12:15 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iEn2j-0007Z4-MU; Mon, 30 Sep 2019 00:12:13 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEn2Z-0002Ps-Jh; Mon, 30 Sep 2019 06:12:06 +0200 In-Reply-To: <83eezzfh8c.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Sep 2019 14:56:51 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240402 Archived-At: Eli Zaretskii writes: >> Uhm... what about... image-use-external-converter? > > SGTM. OK; done. > But that means the command strings are restricted in what they can > use, because split-string has some limitations that aren't immediately > evident. So if you want to leave this stuff as-is, at least we should > say something in the doc string of image-converter--converters to that > effect that; e.g., I think quotes should not be allowed there. Stefan M. suggested using a list instead of a string, and I think I'll make that adjustment. > Maybe. It sounds a bit too convoluted to me, and I hoped for a > simpler solution... Me too, but I don't see one at the moment. > Actually, why not simply add the relevant extensions to > auto-mode-alist, causing them to invoke image-mode? But when do we do that? To determine what the list of supported formats is, we have to run `image-converter--probe' (etc). But we don't know whether we need to do that until we know that we're going to load an unsupported image format. :-/ I.e., we want ("*.webp" . image-mode) in auto-mode-alist, but we can't put it there before we've called "gm convert -list format", and we don't do that until we call `create-image' with image-use-external-converter non-nil, which won't be called since we don't have a mapping from "*.webp" to image-mode. Very chicken and egg. Hm... One possibility would be to do away with (setq image-use-external-converter t) as a user-level thing, and instead tell them to do (image-external-converter-mode) in ~/.emacs, which would do the probing and then altering auto-mode-alist. Hm. Perhaps that's a pretty clean idea? Hm... I think so. Except that switching the mode off would have to remove the entries from auto-mode-alist again, which sounds slightly destructive. Uhm. Perhaps map .wepb etc to a new image-mode-external that should just be a mode that inherits from image-mode, but would do nothing if the image-external-converter-mode has been toggled off? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no