From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Fri, 01 May 2020 23:45:56 +0200 Message-ID: <87368jba7f.fsf@web.de> References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="43070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 23:51:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUdZ3-000B71-An for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 23:51:21 +0200 Original-Received: from localhost ([::1]:52662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUdZ1-0003q8-VL for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 17:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUdTx-0001Us-HC for emacs-devel@gnu.org; Fri, 01 May 2020 17:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUdTw-0007tj-8J for emacs-devel@gnu.org; Fri, 01 May 2020 17:46:05 -0400 Original-Received: from mout.web.de ([212.227.15.4]:52015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUdTv-0007pU-FP for emacs-devel@gnu.org; Fri, 01 May 2020 17:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588369557; bh=ApMcUGmacTjKkMlenQsCMI4BFFeYPerEitIAomp6zbY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BvJFLFaSF9T/tcBu/hyF5YTL1OaZcErces7vb1tISmHhg6K+/j17bQl+fYkfglVto 331gBjzF2p9vBA6dmgGRPlcnutZ4nrkcAtdsxYW06/s5y9BbVjZ51nvIooB34B8hv6 S1Up9FpecMyH4HrNVeKUgUTUx+iy9P66cdyeUGRc= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.99.168.6]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MGQC9-1jNE1w0cNJ-00GrAt; Fri, 01 May 2020 23:45:57 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 01 May 2020 17:01:39 -0400") X-Provags-ID: V03:K1:35R5427jli39eU58793eG2IDrX+jrKiMd4iUMiXhka7CnIO0N47 w5t402HnudjKElGpFQ7guNfJtgYCewY5El1YbCyReIDGpj7Z8w5yCG7Y/T54jIJqSEyzLDz lrls093C1g3q01wRns8LAMl+J7G39EbYRMDWUh8JSI79thtpqKqzWz3Y9h6bsd+xTUvYqJL mhXJeMnEGU7nxRxHdy+Pw== X-UI-Out-Filterresults: notjunk:1;V03:K0:3pQjE+3swkY=:TzE3qfzcQztaTA5BGBf0tT jQ73OQlaisIzoNe+f4FDKp0YOGUntmv0raDKHzt2TC9sTAHafT8hDD2MTWNLpvuTt/Ug29YF8 +lkonlwHqp9S7wOgKh9d4KEr2AAQpNWGi6Nkq8sF3uo3H5Xp6a14wtE6eCTOQLSC9ZjlEWQVM tggBTf8PBPPtDD1ONEVHWtLLXM+MJ1OzTOZPeqHOuxWr3cdxtiglcJHmau/pWdyL+Ad0clZBl HT6AbP0T01Yweggfe6rHkmgultyhTd2TFIJ2dcE1qI/0F4swtEataEdquT4HYq/u//nLpuFir 73C05WkkEEfpYvHWCleVKizWrz2qtsof88bhYg1FEBrUnmYxA3VGYNt/1Q1q/yBaOL3lniBsS 4BwFbfQsWHzEjZ+k331TKbgx+h9E7+t7L9MRd7/XZETJc3y5NmlRy90Tnwl038c74PmFqe4yF gqkI1oGK6nMgxy/AbFEmrdw7eYgH3zo7ECD4t0iKEaUYjQFq1lj7A3ldBqMMMvriosBICgsSv y773MFZ84YuU3z75i3evSUzHe0xwh604h/5gFbf9JH1/vUCZDFvCdJthyZXXu/91fufdy3Ha1 P5RUHPigpp+yQQ78LRvbr56yptKn+yYzPsofnph4lnO426X1vU8sE//EFG9ecKFq4P4TxSYXE kEkZXInysiBc0lpb9Q9uN2ybkoIugFTfq0921OjTgeGlqkzzMnIz68nN25pnKGRN7SBxQ9Ijr /pXUWv756kYvXkbRmaVG9IP9mOPelInQKE/KvYpw0/PagZZW7IsdnoDiJWmnmL8exU+8pyPo Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 17:46:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248344 Archived-At: Stefan Monnier writes: > > Inhibit modification hooks when saving eieio-persistent's > > > > * lisp/emacs-lisp/eieio-base.el (eieio-persistent-save): Bind > > inhibit-modification-hooks -> t. > > I think this deserves an explanation (as a extensive comment explaining > why it's needed and why we think it's safe to do it here.) I thought this would be obvious? The output always goes into a fresh temp buffer the user never sees, and the goal is to speed things up. Sure, I can add a comment, but I don't know how I can achieve the "extensive". Michael.