From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's
Date: Mon, 04 May 2020 14:09:39 -0700 [thread overview]
Message-ID: <87368fxv8s.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87v9ldfvn5.fsf@web.de> (Michael Heerdegen's message of "Sun, 03 May 2020 07:13:50 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> > After having identified the culprits in my case - all of them can be
>> > fixed - there is not much speedup left from this particular change.
>> > Given that, but also given that we don't know what other people might
>> > have added there - do you think that using `combine-change-calls' in
>> > this case is justified, Stefan?
>>
>> I hope not ;-)
>
> Then Eric I think it's your turn now to check (profile) if this is at
> all helpful in your case. Could you please try that?
Okay, I started with the existing `inhibit-modification-hooks' edit.
Saving both the gnus registry (not many objects but they're pretty
large; file is 30M) and one of my EBDB databases (many objects but
they're quite small; file is 550K). Basically just loaded both objects
into a variable, and then repeatedly saved the object with
`eieio-persistent-save'.
;; With modification hooks uninhibited (ie, reverting Michael's commit).
(benchmark-run 100 (my-save-registry)) -> (1028.64836554 2801 537.1068782020001)
(benchmark-run 100 (my-save-ebdb)) -> (51.585404029 134 20.779424303000003)
;; With modification hooks inhibited (Emacs master).
(benchmark-run 100 (my-save-registry)) -> (989.206686569 2800 526.325465032)
(benchmark-run 100 (my-save-ebdb)) -> (63.946958194 127 23.392065172000002)
I haven't tried it with `combine-change-calls' or any of the other
speedups (gc-cons-threshold, etc), mostly because I've also been trying
to get work done. But I can test with any combination of changes, as
needed.
Eric
next prev parent reply other threads:[~2020-05-04 21:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200501192115.23847.67499@vcs0.savannah.gnu.org>
[not found] ` <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org>
2020-05-01 21:01 ` master c59e878: Inhibit modification hooks when saving eieio-persistent's Stefan Monnier
2020-05-01 21:45 ` Michael Heerdegen
2020-05-01 22:03 ` Stefan Monnier
2020-05-01 22:24 ` Michael Heerdegen
2020-05-01 22:40 ` Stefan Monnier
2020-05-01 23:30 ` Michael Heerdegen
2020-05-02 13:26 ` Stefan Monnier
2020-05-02 21:08 ` Michael Heerdegen
2020-05-02 22:09 ` Stefan Monnier
2020-05-03 2:44 ` Michael Heerdegen
2020-05-03 4:01 ` Stefan Monnier
2020-05-03 5:13 ` Michael Heerdegen
2020-05-04 21:09 ` Eric Abrahamsen [this message]
2020-05-04 21:36 ` Michael Heerdegen
2020-05-04 21:42 ` Eric Abrahamsen
2020-05-02 4:24 ` Michael Heerdegen
2020-05-02 0:03 ` Eric Abrahamsen
2020-05-02 0:22 ` Michael Heerdegen
2020-05-02 13:32 ` Stefan Monnier
2020-05-02 18:18 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87368fxv8s.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).