unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Alan Third <alan@idiocy.org>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: 68033285 * .gitlab-ci.yml (test-all): Run only when needed.
Date: Mon, 31 Aug 2020 09:03:38 +0200	[thread overview]
Message-ID: <8736435mb9.fsf@gmx.de> (raw)
In-Reply-To: <20200830192159.GC65922@breton.holly.idiocy.org> (Alan Third's message of "Sun, 30 Aug 2020 21:22:02 +0200 (CEST)")

Alan Third <alan@idiocy.org> writes:

> Hello Michael,

Hi Alan,

> I think you may have made a copy/paste mistake with the wildcards in
> this commit.
>
> "- src/*.{h,m}" means any file with a .h or .m extension but I guess
> you intended src/*.{h,c}. There are a lot more types of files in src/,
> though, so I don't know if it should just be src/*?

There aren't so many files except *.c and *.h which matter. But these
other files are changed not very often, so it might be OK.

OTOH, I don't know what happens if a file is matched in both
only/changes due to src/*, and in except/changes due to src/ns*.{h,m}.

> The w32 files have the same problem.

Oops, yes.

If you like you might fix it as proposed.

> Since we're now excluding the test-all job from running when NS .m
> files are updated, should we add make check to the end of the
> test-gnustep job?

Fine with me. Does a gnustep Emacs build runs also in a Debian environment?

Best regards, Michael.



  reply	other threads:[~2020-08-31  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-30 19:22 68033285 * .gitlab-ci.yml (test-all): Run only when needed Alan Third
2020-08-31  7:03 ` Michael Albinus [this message]
2020-08-31  8:23   ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736435mb9.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).