From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Fri, 18 Sep 2020 12:31:44 +0200 Message-ID: <87363f9y0f.fsf@gmx.de> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <87pn6rgtcl.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 12:35:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJDjt-00043F-56 for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 12:35:37 +0200 Original-Received: from localhost ([::1]:59764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJDjr-0001zj-Uo for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 06:35:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJDgI-0008WS-Lj for emacs-devel@gnu.org; Fri, 18 Sep 2020 06:31:54 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:37019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJDgG-0004pO-CM for emacs-devel@gnu.org; Fri, 18 Sep 2020 06:31:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600425106; bh=TeK6J/fHi0AigJMBK0S1GWoJoYjO5qUlkF0ZWzJfLr0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LMLTsQ5Sc16yfN0iZj1dLcbwnBiyb55yH0aZgj9S0mIS4fmdLQF6SwbiSClLW1uA3 Q6CYus0SAgXZ9WRTrTBg8KJzmln+hHyIqUPJmgwg5JnoZoL4+s1ny1QPW3K8DTX36U PdBpj/iGXysA/dfMI4xxmD0SnOmHI4g9sDJiTfO8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([178.20.93.248]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MybKf-1kgWtD2o4j-00ywer; Fri, 18 Sep 2020 12:31:46 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 18 Sep 2020 03:22:54 -0700") X-Provags-ID: V03:K1:jBEjEFpzv+gKSCxRYlEBjXmNH6/PovUhoYt2xGtnKVZVAoixXiO qmFXKo63RLlxDRjksnRecWscQF7yqLmmkuuufrCWJ4txnMRdC01Y1pP19zw9MtgYihn6FmH uCYiWR6xF956oelXo/pKLGkOn0S6s+KelqQJAcVfELaVtegNp726tEpleLEXkf7KWSGMwUM GV0Y/R7TOof0CNSSg5L4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:6Cetb16k+Zc=:5/9+r9ICqEKLMEevohQWkK tG4QROOGUoXeDIuWtDdmf5s+b8jj+nugrTY6vAorPFM/CgpffxAjQySgKSQDGQ52OphnG2DgN 9BKZiYlUZyskYQ1Aw0q4N1KtpRcTdXpHNN49+i/qwESAq9G4HKJ1XMtXeD3r/E2t2j54rwddo 1cPxStbqGfLF32uuXSclTPX+4zdpqJOetTIIU/Cw+zf12xFABwkXPsuXAgovAZZuVyA0ICAae WRMM0v5XrHsbve2/aNrAUmZSdPgPB7NafABCZUqH9p/2YtLSHCN62v4RAUReYwRPBdee+/EqC TxJKVYSHMfGnFYKlZwkCuyxitWBC8tCFFSvSoIb4fhw/AaPL7TdHzEQnFhKgbnyZ3ldLSzVjH pAeT3iMHjuI3X20S/f50tHXLSFJsrR7t3IOlHHdsokCtQKvcqOIOc2qEjnAzom3sCDBZY9wFc v5s2nDqzZr+D5dC4ZEAx5HL6r0xwkX2U7vBVWzBE/9/6rBIvUgpPWHBs059yj61mKOr0WAlLj ntYJdE1Sx6lBzTr5zKY4/eU85UxVJxWTuSJpO+8IIgi7+T5SfIsCQzAxBfSV3o0gqw1qsHqV9 zJCg8+HE32kXWzcqk2egegMbKa/gyQjMFgQfnf2T1P7v1szMA92Os/jZHausmIdYjbh3mgaxK BD/50o6+HDMT3tLs+o2UKr1MbbFbvLDxjl4VDZA292RTOk0W2tYcT6vLR0TQTjRC2j2JYCjfh XE7bU/YJgujo09xYRfs8WUkKZP4dHOTOfydMZFy6JFbKwf0+1YH18PoOu9Ccl1lLlxrB82FB Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 06:31:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256072 Archived-At: Stefan Kangas writes: Hi Stefan, > It does seem unfortunate that no tests run for autorevert-mode in the > default case. I have a patch in the works that will reduce the running > time for these tests, I will send it here when it's done. (Basically > the patch would temporarily lower auto-revert-interval, remove sleeps > and manually set mtime to lower values than the current time.) Would be helpful. However, there have been discussions (and changes) of the timeouts in the past, so I'm not sure we can reduce them w/o causing damage. Please check the git history of autorevert-tests.el for such changes, hopefully there are bug numbers in the git log you could consult for the respective discussions. Otherwise, a search on the emacs-devel and emacs-bugs MLs for the given timeframe of such a change might be helpful. >> There have been discussions about how long tests shall run. But there >> hasn't been ever a conclusion to limit them to 1 second. Please discuss >> this first, before making such changes. > > Sure, I just didn't expect this to be controversial. Sorry if this > change caused any problems. IIRC, this discussion happened before you've started with work on Emacs. I'm pretty sure there's something in the emacs-devel ML, but this was years ago. > Best regards, > Stefan Kangas Best regards, Michael.