unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: spacibba@aol.com, Jean Louis <bugs@gnu.support>,
	andreyk.mad@gmail.com, emacs-devel@gnu.org, rudalics@gmx.at,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Gregory Heytings <ghe@sdf.org>, Eli Zaretskii <eliz@gnu.org>,
	Drew Adams <drew.adams@oracle.com>
Subject: Re: on helm substantial differences
Date: Fri, 20 Nov 2020 11:24:24 +0200	[thread overview]
Message-ID: <873614ido7.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y2iybe27.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  18 Nov 2020 22:33:20 +0200")

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

> BTW, using `affix-function' also makes it possible to group completions,
> then the prefix of the first completion in the group could contain
> a group header with group name.

'mule--ucs-names-annotation' has this comment:

  ;; FIXME: It would be much better to add this annotation before rather than
  ;; after the char name, so the annotations are aligned.

With `affix-function' it's possible to add the char before the char name.
Adding groups is also simple (I recall that Richard asked to group by blocks).


[-- Attachment #2: chars-groups.png --]
[-- Type: image/png, Size: 47736 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: mule--ucs-names-by-group.patch --]
[-- Type: text/x-diff, Size: 2197 bytes --]

diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index d361971a1f..f536c10a13 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -3092,6 +3092,37 @@ mule--ucs-names-annotation
   (let ((char (gethash name ucs-names)))
     (when char (format " (%c)" char))))
 
+(defun mule--ucs-names-by-group (names)
+  (let* ((names-chars
+          (mapcar (lambda (name) (cons name (gethash name ucs-names))) names))
+         (groups-names
+          (seq-group-by
+           (lambda (name-char)
+             (let ((script (aref char-script-table (cdr name-char))))
+               (if script (symbol-name script) "ungrouped")))
+           names-chars))
+         names-headers header)
+    (dolist (group groups-names)
+      (setq header t)
+      (dolist (name-char (cdr group))
+        (push (list (car name-char)
+                    (concat
+                     ;; header
+                     (if header
+                         (progn
+                           (setq header nil)
+                           (concat "\n" (propertize
+                                         (format "* %s\n" (car group))
+                                         'face 'header-line)))
+                       "")
+                     ;; prefix
+                     (if (cdr name-char) (format "%c" (cdr name-char)) " ")
+                     " ")
+                    ;; suffix
+                    "")
+              names-headers)))
+    (nreverse names-headers)))
+
 (defun char-from-name (string &optional ignore-case)
   "Return a character as a number from its Unicode name STRING.
 If optional IGNORE-CASE is non-nil, ignore case in STRING.
@@ -3138,8 +3169,10 @@ read-char-by-name
 	   prompt
 	   (lambda (string pred action)
 	     (if (eq action 'metadata)
-		 '(metadata
-		   (annotation-function . mule--ucs-names-annotation)
+		 `(metadata
+		   ,(if completions-detailed
+                        '(affix-function . mule--ucs-names-by-group)
+                      '(annotation-function . mule--ucs-names-annotation))
 		   (category . unicode-name))
 	       (complete-with-action action (ucs-names) string pred)))))
 	 (char

  reply	other threads:[~2020-11-20  9:24 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 17:42 on helm substantial differences Drew Adams
2020-11-13 21:16 ` Jean Louis
2020-11-15 11:49 ` Jean Louis
2020-11-15 20:07 ` Juri Linkov
2020-11-15 22:01   ` Stefan Monnier
2020-11-15 22:41     ` Drew Adams
2020-11-16  8:58     ` Juri Linkov
2020-11-16 16:03       ` Drew Adams
2020-11-16 17:36       ` Stefan Monnier
2020-11-16 20:38         ` Juri Linkov
2020-11-16 21:54           ` Stefan Monnier
2020-11-17 19:18         ` Juri Linkov
2020-11-17 20:32           ` Juri Linkov
2020-11-18  9:10             ` Juri Linkov
2020-11-18 11:38               ` Basil L. Contovounesios
2020-11-18 19:13                 ` Juri Linkov
2020-11-18 20:33                   ` Juri Linkov
2020-11-20  9:24                     ` Juri Linkov [this message]
2020-11-20 11:57                       ` Eli Zaretskii
2020-11-20 12:15                         ` Eli Zaretskii
2020-11-20 14:39                           ` Stefan Monnier
2020-11-21 20:18                           ` Juri Linkov
2020-11-22  3:33                             ` Eli Zaretskii
2020-11-22  8:36                               ` Juri Linkov
2020-11-22 15:19                                 ` Eli Zaretskii
2020-11-22 20:11                                   ` Juri Linkov
2020-11-23  3:24                                     ` Eli Zaretskii
2020-11-25  9:10                                       ` Juri Linkov
2020-11-25 15:51                                         ` Eli Zaretskii
2020-11-25 19:16                                           ` Juri Linkov
2020-11-25 19:59                                             ` Eli Zaretskii
2020-11-25 20:35                                               ` Juri Linkov
2020-11-26 13:45                                                 ` Eli Zaretskii
2020-11-27  8:45                                                   ` Juri Linkov
2020-11-27  8:58                                                     ` Eli Zaretskii
2020-11-27  9:17                                                       ` Juri Linkov
2020-11-17 21:14           ` Jean Louis
2020-11-18  9:03             ` Juri Linkov
2020-11-18 19:21           ` Juri Linkov
2020-11-18 22:04             ` select yank via completion Stefan Monnier
2020-11-18 23:02               ` Drew Adams
2020-11-19  7:54               ` Juri Linkov
2020-11-19 17:00                 ` Drew Adams
2020-11-20  8:53                   ` Juri Linkov
2020-11-20 11:53                     ` Eli Zaretskii
2020-11-21 19:38                       ` Juri Linkov
2020-11-21 19:57                         ` Eli Zaretskii
2020-11-21 20:43                           ` Juri Linkov
2020-11-20 14:23                     ` Stefan Monnier
2020-11-21 19:42                       ` Juri Linkov
2020-11-21 21:08                         ` Stefan Monnier
2020-11-21 22:21                         ` Drew Adams
2020-11-21 22:48                           ` Jean Louis
2020-11-21 23:00                           ` Jean Louis
2020-11-25 19:25                           ` Juri Linkov
2020-11-25 19:40                             ` Drew Adams
2020-11-21 21:54                       ` Drew Adams
2020-11-21 21:46                     ` Drew Adams
2020-11-24 22:59                     ` Basil L. Contovounesios
2020-11-25  7:36                       ` Juri Linkov
2020-11-25  8:14                         ` Andrii Kolomoiets
2020-11-25 20:24                           ` Juri Linkov
2020-11-26  8:46                             ` Basil L. Contovounesios
2020-11-26  9:26                               ` Juri Linkov
2020-11-26  9:57                                 ` Eli Zaretskii
2020-11-26 21:17                                   ` Basil L. Contovounesios
2020-11-27  7:13                                     ` Eli Zaretskii
2020-11-27  9:01                                       ` Juri Linkov
2020-11-18 22:36             ` on helm substantial differences Drew Adams
2020-11-16 16:13   ` Eli Zaretskii
2020-11-16 20:41     ` Juri Linkov
2020-11-16 21:18       ` Drew Adams
2020-11-16 22:13         ` Juri Linkov
2020-11-17  0:04           ` Drew Adams
2020-11-17  8:38             ` Juri Linkov
2020-11-17 16:56               ` Drew Adams
2020-11-17 12:06             ` Protesilaos Stavrou
2020-11-17 17:29               ` Drew Adams
2020-11-17 19:23               ` Juri Linkov
2020-11-17  3:24       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873614ido7.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=andreyk.mad@gmail.com \
    --cc=bugs@gnu.support \
    --cc=contovob@tcd.ie \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ghe@sdf.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).