From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Wed, 03 Mar 2021 15:16:54 +0000 Message-ID: <8735xctggp.fsf@tcd.ie> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32000"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 16:18:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHTGJ-0008Ab-NR for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 16:18:07 +0100 Original-Received: from localhost ([::1]:50704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHTGI-0005zJ-PU for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 10:18:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHTFF-00050Z-Ni for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:17:01 -0500 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:37996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHTFC-0003tk-AN for emacs-devel@gnu.org; Wed, 03 Mar 2021 10:17:00 -0500 Original-Received: by mail-wr1-x42f.google.com with SMTP id d15so8851047wrv.5 for ; Wed, 03 Mar 2021 07:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5H9q7lU2X2fKLpuouT2pscGQlZkpkRG2rq6zXiJyT6o=; b=RYvTcwnUcTbNy1kfDgjA4pMURwoRpEVw6ql6aTO2oZZrKZuXalexoDnj8VW5SFcPLn LIk604ivN+VI7KOWLglBKT9AyXbkL6PBuoWBHKK8RXtGOpFjD8LJbDMVNBZM5X0aEKxO 0CJyaLQbpeHzPBO8ClkZ8wwnUV/1LqlxaDvWObaksiKBFnYLe9rcg2AzLpPgCpYS0g5m AGUORSuYs8JOqiNN91Z6rsPuSgmp76noGdouNASDIuAiQpOXoPEWiR3NR7f6fDku8hbr XYgZsfR8bnTslCEYFRRh4nT5al6mIqLwS/X9KygeZrCCE/mHJ+wcIauasmlL4FONyeW4 823g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5H9q7lU2X2fKLpuouT2pscGQlZkpkRG2rq6zXiJyT6o=; b=nTxIltMeRjqiEBAI9/PtsR06uPSFI2+p7Nl9bnAtM2eC1RdwjVFA9BA9WnjWOAzkbf DXn7Ho8GJCO0yhBeV40TyAgg0gwayvHeJEyHSdwNOF0oXtc9LiEQHbOXXSbwEzf6KbzE eJpf8g1HvSUHJl12oe6bQhcKDEHHWKiH+U7gzHAEZWPMbg8YAL9URKrRPHzZBTFeW3zP OJQelGHH4u3HZWLHaROgrA3+SvULL0HmP7B053ngcQDr4jCqDgrwCvUp/G3/Z41fHX2d L5zQxXIU9z9lf5umJihgAGBIPF6Y516e44lwwCPVjkOSN9Ovjzv+4D/+TOrctaFbweMS b3Dw== X-Gm-Message-State: AOAM530Tht0oN9h2lQ5qGOtKXiTETTK8DSf6bM94q+TDOOUjKk4XUA8s ivsu2jrhawjunnk/xoUuQg7j9A== X-Google-Smtp-Source: ABdhPJxWUOvi+fO+wAk3CCVBLRCi8GNhTCGSv0mqljygZGBNHyl1GF0twyw18fZafDX/crOEcAgSwQ== X-Received: by 2002:adf:e60a:: with SMTP id p10mr27949391wrm.291.1614784616506; Wed, 03 Mar 2021 07:16:56 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id m17sm12275958wrx.92.2021.03.03.07.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 07:16:55 -0800 (PST) In-Reply-To: <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 3 Mar 2021 16:01:34 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265884 Archived-At: Mattias Engdeg=C3=A5rd writes: > 3 mars 2021 kl. 15.44 skrev Basil L. Contovounesios : > >> This seems to result in the following test failure with 'make check', >> but strangely not with 'make test/pcase-tests': > > Maybe the latter doesn't use the byte-compiled version of the tests. > Try something like > > make TEST_LOAD_EL=3Dno -C test pcase-tests Indeed, 'make TEST_LOAD_EL=3Dyes test/pcase-tests' succeeds, whereas 'make TEST_LOAD_EL=3Dno test/pcase-tests' fails. Should 'make test/%' be fixed to behave more like 'make check'? Thanks, --=20 Basil