From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] New package proposal: aggressive-completion.el Date: Sun, 04 Apr 2021 21:05:10 +0200 Message-ID: <8735w5rh3s.fsf@gnu.org> References: <87o8evok58.fsf@gnu.org> <8735w7y98k.fsf@gnu.org> <87mtue5f6x.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.11; emacs 28.0.50 Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 04 21:22:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT8KH-0008PB-HU for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Apr 2021 21:22:25 +0200 Original-Received: from localhost ([::1]:53866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT8KG-0004Iy-Ih for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Apr 2021 15:22:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lT8JB-0003ZZ-Px for emacs-devel@gnu.org; Sun, 04 Apr 2021 15:21:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44585) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT8JB-0005Zx-7e; Sun, 04 Apr 2021 15:21:17 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:53975) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lT8J9-0006Kk-FA; Sun, 04 Apr 2021 15:21:17 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id E766627C005A; Sun, 4 Apr 2021 15:21:14 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 04 Apr 2021 15:21:14 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejtddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe evveeikeetkeeviefgfeffiedvteeguddvffeuueduveegtddthedvhfeuveffhfenucfk phepkeejrdduieefrdefuddrudehgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA id E81911080057; Sun, 4 Apr 2021 15:21:13 -0400 (EDT) In-reply-to: <87mtue5f6x.fsf@tcd.ie> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267393 Archived-At: "Basil L. Contovounesios" writes: Hi Basil, >> (defcustom aggressive-completion-no-complete-commands >> '( left-char icomplete-fido-backward-updir minibuffer-complete >> right-char delete-backward-char backward-kill-word >> backward-kill-paragraph backward-kill-sentence backward-kill-sexp >> delete-char kill-word kill-line completion-at-point) >> "Commands after which automatic completion is not performed." >> :type '(repeat command)) > > Customising this gives an error, because there is no such thing as a > 'command type (yet). It should probably be '(repeat function). Indeed. I've just fixed that in 1.2. Also, that variable is now `aggressive-completion-auto-complete-commands' because Stefan made me aware that a whitelist of commands after which auto-completion kicks in is much more compact than a blacklist of commands where it shouldn't kick in. And then I got a (wrong-type-argument number-or-marker-p tab), fixed it, and pushed 1.3 some minutes after 1.2. How hard can it be to get it right on the first try?!? ;-) > Thanks for the cool package, You're welcome! Bye, Tassilo