From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: NS port cleanups Date: Sat, 23 Oct 2021 19:20:28 +0800 Message-ID: <8735os7zsz.fsf@yahoo.com> References: <87czo3bxog.fsf.ref@yahoo.com> <87czo3bxog.fsf@yahoo.com> <8735ox9wtu.fsf_-_@yahoo.com> <87mtn4edf7.fsf@yahoo.com> <8735owcmrl.fsf@yahoo.com> <87bl3jc1bz.fsf@yahoo.com> <87ee8f8c3z.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11390"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs-Devel devel To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 23 13:22:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1meF6C-0002kR-3f for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Oct 2021 13:22:04 +0200 Original-Received: from localhost ([::1]:38128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meF6B-0005rH-42 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Oct 2021 07:22:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meF4q-0004gX-1g for emacs-devel@gnu.org; Sat, 23 Oct 2021 07:20:40 -0400 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:37713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meF4n-0005n2-Bl for emacs-devel@gnu.org; Sat, 23 Oct 2021 07:20:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634988035; bh=zaWkjLF1tdrleDFPgf42Cs7rwTuN7qQdcejp82Ibwjs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=riGgzr3t9mOIYGwTPlvCrB5h4kJI+axGhgNIHBMAKUGW01X+QpEYQOgiPVmVwlSj92KxRhX+hWLZKSMGTN344+wsYk0h2Yix7YDlpQJ6L0ViaShTFt0LHUWMBgPgQpz4av6+qMjC9vVQX2VwDXvkaZ5+1KptPFwnYn4EH4dyHR6G0AfdwCTCK9qH3A4xNp5OObFelLsFZX6h4PJA0wdSUFE80UwmAPGyiDU3v6kesLp39lWDvGKsHiyvoel1ZhteV09Dtkcl5KxnLAbcrf5cWFu4a772ZjQZudXA5r7iaj/WQOMKqosLIyMt3OQpGKyTOT753atYGL7P77puIDDujg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1634988035; bh=Cbu34BTGqPoo2gm2155sZMzfH0ZL18Mq2wV+tsMMqUJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bNg2kH9jmCT0TVO0GZxf93tcMV6JoCqjkRqmToLgb3VdFGuBqMiRKCbvnhsr6SNzwzRTfI3oFSntX/DG2uMLN7FJYvDvLM4e3WPDl/HoogAYvr9AtnURU66XCtXfQQeKEH3LpVLlibd/Q5AFNL2BJ6ujWIe7P/W31zWEiapTphe0kkyd5CbEiN5g3a9kgrfstNuWoEB225WJmsxPgK5p0Exq+vGk/kHJ09uVyPVnkSPAOE1rLRRK7edNJAmCMnu0oTGlvH0DWOlaVrU+Q1rHPGAFAYw4VYRzZ6Jzkh95CtjfhbV+VN66TcnPMOJluiCQVrQR6B4q7kgo5DUwF+mF2A== X-YMail-OSG: MlcI58YVM1mjYBltnj2NODnqBZn7uAS2hyA9klsQXOOhg5qNdVsOhkErv1S6glM CrFL0YYxPWUNVchY7C3cewV38RQDm_jD1IDJtt544uHUOPZAGNz0l9vv7.s2rrU65ijZk96xOO8U xbj1IvbKdUl.OQYDc7K4G4KyRpr7eWU8nViDKJy.EX2R4.ncQNqBgBAQJvVMfMf04AFllCPCJFrh jZSLKAmM5JYUcozzBOXPDTB84t3AOmD.d3t1_rSEPvoYAL91tM.8h8VNCNRbjnmd9E8SG.i2SAkN wtgnmk_cBX_BCot3vQOG67v2Vh1y28rZGAnYZvmNm3GQDVT32R5_aizd6bH9Ry7sVHjp6k74csUK Xn3_pPIpfqJRvlp2jqWLVEi_xyZoaqgGV5kAmrGLwGjKoPaSNJaW4_mFPY_mQ_kIueHFZXaFdmuL wqjTpBJa5I7V3saS_WQ1YdzWkAORbtsfuEzqhtlISS0xMLW1iDlIqbdLHxUyDG2_OIoH9S9RHZ_d 3stN4tTDmEbipD66GA3_YwzRMCvrugcZs3zHfar7T9TWHR2.zNeEcgjEYG1oSMoTsjOV5pamDbFL WpCYCxfNehHOsAd7blz8LDnULr6DPORYJ2eEbaB8b82f6D70FgZKZ5u84gkEL0ERL4Am2RWOgHk0 78SJgxQZauyy_X4agFy2Xy_3d95EhZOgRV0disFq0JtWaV685cdRPtDFeoltboqNmJ_ZsIB7FHwN 0uAXsolZWr0w1.GGx2UnbT2ER5NaWnQn168SODqAE.B6zDH_CjZwvLuFp0OhWw7CpEPW6WGSLpuH UOqandtAk5uYZuoD_xknNVGByB.pE7Q4sQFmjSfTko X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 23 Oct 2021 11:20:35 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID bfc7bec43bbd70f6716946ea9679ab39; Sat, 23 Oct 2021 11:20:32 +0000 (UTC) In-Reply-To: (Alan Third's message of "Sat, 23 Oct 2021 10:09:54 +0100") X-Mailer: WebService/1.1.19198 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277612 Archived-At: Alan Third writes: > I think I forgot to ask you to make these changes: > > modified src/macfont.m > @@ -2924,7 +2924,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no > { > if (s->hl == DRAW_CURSOR) > { > - CGColorRef *colorref = get_cgcolor_from_nscolor (FRAME_CURSOR_COLOR (f)); > + CGColorRef colorref = get_cgcolor_from_nscolor (FRAME_CURSOR_COLOR (f), f); > CGContextSetFillColorWithColor (context, colorref); > CGColorRelease (colorref); > } > @@ -2940,7 +2940,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no > CGContextScaleCTM (context, 1, -1); > if (s->hl == DRAW_CURSOR) > { > - CGColorRef *colorref = get_cgcolor_from_nscolor (FRAME_BACKGROUND_COLOR (f)); > + CGColorRef colorref = get_cgcolor_from_nscolor (FRAME_BACKGROUND_COLOR (f), f); > CGContextSetFillColorWithColor (context, colorref); > CGColorRelease (colorref); > } Thanks, applied. I'll split the patch up and let you know.