From: Po Lu <luangruo@yahoo.com>
To: Alan Third <alan@idiocy.org>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: NS port cleanups
Date: Sat, 23 Oct 2021 19:20:28 +0800 [thread overview]
Message-ID: <8735os7zsz.fsf@yahoo.com> (raw)
In-Reply-To: <YXPRYucrE1SEGEa3@breton.holly.idiocy.org> (Alan Third's message of "Sat, 23 Oct 2021 10:09:54 +0100")
Alan Third <alan@idiocy.org> writes:
> I think I forgot to ask you to make these changes:
>
> modified src/macfont.m
> @@ -2924,7 +2924,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
> {
> if (s->hl == DRAW_CURSOR)
> {
> - CGColorRef *colorref = get_cgcolor_from_nscolor (FRAME_CURSOR_COLOR (f));
> + CGColorRef colorref = get_cgcolor_from_nscolor (FRAME_CURSOR_COLOR (f), f);
> CGContextSetFillColorWithColor (context, colorref);
> CGColorRelease (colorref);
> }
> @@ -2940,7 +2940,7 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no
> CGContextScaleCTM (context, 1, -1);
> if (s->hl == DRAW_CURSOR)
> {
> - CGColorRef *colorref = get_cgcolor_from_nscolor (FRAME_BACKGROUND_COLOR (f));
> + CGColorRef colorref = get_cgcolor_from_nscolor (FRAME_BACKGROUND_COLOR (f), f);
> CGContextSetFillColorWithColor (context, colorref);
> CGColorRelease (colorref);
> }
Thanks, applied.
I'll split the patch up and let you know.
next prev parent reply other threads:[~2021-10-23 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87czo3bxog.fsf.ref@yahoo.com>
[not found] ` <87czo3bxog.fsf@yahoo.com>
2021-10-17 19:00 ` bug#51251: 29.0.50; Moving cursor on top of raised box leaves artifacts around in NS port Alan Third
2021-10-19 9:40 ` NS port cleanups Po Lu
2021-10-19 20:22 ` Alan Third
2021-10-20 0:40 ` Po Lu
2021-10-20 5:01 ` Po Lu
2021-10-20 12:44 ` Po Lu
2021-10-20 20:12 ` Alan Third
2021-10-21 0:17 ` Po Lu
2021-10-23 8:58 ` Alan Third
2021-10-23 11:19 ` Po Lu
2021-10-23 9:09 ` Alan Third
2021-10-23 11:20 ` Po Lu [this message]
2021-10-23 12:00 ` Po Lu
2021-10-23 19:31 ` Carlos Pita
2021-10-25 11:33 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735os7zsz.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).