From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] new package: sndio.el Date: Sun, 14 Nov 2021 18:32:09 +0000 Message-ID: <8735nyeggm.fsf@posteo.net> References: <87tugfw1yg.fsf@omarpolo.com> <87bl2meh4h.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11137"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Omar Polo , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 14 19:33:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmKJT-0002iH-TY for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 19:33:11 +0100 Original-Received: from localhost ([::1]:49052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmKJS-0001Bx-1b for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Nov 2021 13:33:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmKIa-0000O1-Lr for emacs-devel@gnu.org; Sun, 14 Nov 2021 13:32:16 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:56151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmKIY-0000Jv-Cx for emacs-devel@gnu.org; Sun, 14 Nov 2021 13:32:16 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 2B788240107 for ; Sun, 14 Nov 2021 19:32:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1636914732; bh=8OgfvNVZGiytdL28FDtekCerRinqyJczfpifc4fk3ZQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=qqoaZIoFWKcdSQfI/SBgSEty9WNVPkEE91TLm3yUQjq6/edf0EWFEo5gmtRaQ+6uq Ej3QToyt+p+wOkR7OP6L5ZbD3tOge3tgS7A0V4MRx90gg67xpm0mKobLKn/wlm8yUt wVD8B0o/VRk10KcR7TdZTFewjxvNuYu+55pPRqFiD+ahXS2Ezp+RW9YZsPEUV3d0Xy X685QiAc4VRIA7Y/fNyok1tAVUbN3fhgiXtCAMYJPYEB9bFFG/tx3yzWurpNTrA963 latv6KTuovjKUSxp5BC4zmAe3s+QHnkzBErqiKpzfI+SpEOjKqZAh/rWfKgky+hSqq HHqipCQmZrEkw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HsgsQ67D7z6tmT; Sun, 14 Nov 2021 19:32:10 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Stefan Monnier's message of "Sun, 14 Nov 2021 13:29:07 -0500") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279437 Archived-At: Stefan Monnier writes: >> From what I see, if I were to download and run the package on a GNU >> System without sndio, there wouldn't be any clear error message >> indicating what went wrong, just an error message indicating that >> sndioctl has failed, right? (this is just from reading and using faulty >> mental evaluation). If the package is to be added to GNU ELPA, you >> should probably add a explicit error message (perhaps even at compile >> time) to clarify what is missing, and that the package isn't mean to >> work on this system. > > From where I stand, OTOH, I'd ask not to emit an error or warning during > compilation (e.g. I compile all the files in elpa.git and I don't have > sndio). Similarly, don't sign an error when loading `sndio.el` (a > warning is tolerable). I did not consider that. In that case a warning/error is certainly not acceptable. It should probably suffice to just throw an error when calling the autoloaded `sndio' command. -- Philip Kaludercic