From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging the pgtk branch Date: Mon, 06 Dec 2021 12:41:30 +0800 Message-ID: <8735n6pcp1.fsf@yahoo.com> References: <20210811.001515.1312870178782255892.masm@luna.pink.masm11.me> <20211130.004115.1186997531521134959.masm@luna.pink.masm11.me> <83tufn2lh6.fsf@gnu.org> <20211206.010117.1221729564949074065.masm@luna.pink.masm11.me> <83o85v2g02.fsf@gnu.org> <87bl1upn3k.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5051"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Yuuki Harano , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 06 05:42:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mu5po-00018K-0y for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Dec 2021 05:42:40 +0100 Original-Received: from localhost ([::1]:50482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu5pm-00088U-JU for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Dec 2021 23:42:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu5ou-0007Rg-4L for emacs-devel@gnu.org; Sun, 05 Dec 2021 23:41:44 -0500 Original-Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]:44353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mu5os-0001KS-9A for emacs-devel@gnu.org; Sun, 05 Dec 2021 23:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1638765700; bh=L8GzMzR7y4qgTZccUnfWA9W7MWIb75/8riyGDc0XIgA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Ag8f2TKRq5QwjJ4aYs2spobX2uxY5IfeDyrUUMFJdfuRzuyUzOuwdZq958oYUqN5jUlGUQwuH1+pJBguhmv3zpi9VJnvEZiE+DIjDJ5TAod7iGwIm/n+B31RVto42hDE69FK34Z7JpJxp1a3gfDkZ3geWhW6+0gL9X/lFKcAHCgzesEU6xWKPtfp4xB0TI66i9C39DUgzvCpYv412uZHBH9WBTkyX7dIZRrvnNboILx2zXpX5GDfDDFl1LldEDT/wRhHvK555nBjwRU4Vj3Dy1/Gq5JUPiVdSecwztucx87jB8dhLdbQQoNGn8sjKcBnwHn1y89/Q5BoBidgCpb0tw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1638765700; bh=PZPw6cPxgaYaBmZi78VYcnElNXmjzwas/kTuQOz7srY=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Eym2baejFd0fEsV/iCsCVx41x5wZ76QgFowdKd0fKdGE0ZzFj3oLQRic+yd2qlBXSKEqeAxX4h/OFYA6z4Grp1Xp5xbR8uKd6eGcDZh2Qbm81EWkOJTXTTVgXt0qfRDhVMx6giR6jQ+d78+apPhrJgavGWEbSHaWaZtf2d5LMiM4ohfEbjOrzkSf6ECjfkRte7sgrwhgtmXJlU3OQSF9NMp5EtCtxbUofRruZkV6dR3VLT/Lr3MvOoCmLbPeQx8kZtjdbPMBofoCosnF0dNpF5jGbeyAfXVFSP76odXHl3uGa75zn0ub01CKyCRtgqv85jWDVmKFfU9Wq9Wyse7VtA== X-YMail-OSG: UJpjv5EVM1m6GzT6phYe19yXJmMtJtMlp4ufqOvtw_k640HxFa3mw1ffnJPsTY1 s2b9atWIrZjuqYGpJe_A6yFE3S19aTN8WJ9c98xsRdT2aQTUPq3f03qFlQNaHTquqemBPQ56Zgji BJGT5Oi.9nQ8rNoJXyYWanKo7oCYZ_FoLbgHD5Ji9sd1G7t5CXAT6suGO3BwsXc2Z75SCZzz4HnS I6UTq5agZ74N5bB.GI.di0XYS922JWk5We2F8snRuv1sc6va2EBZcsATDmcsM5JWQtqmhKzScW5N GzKCkTeaTAhdxlaNDLa1x6x.kXCLoyDFVvVvf.MfqvVR91VsOJ6Iedi8AiPzLc8J6_eXZ12HHyMT MiiZcPt85_VM9GVbRh090IQ2zFAi9AbumVhbylBS7oms5dnGaHg2Yy8s2LQyYHfjd9YyZPniwMm3 wAVE_bUAIeVEFqahE0wzddtq424ub_RqJT2CdufbgpelrFay3xo3tjtH0Go8wDIJkhl1A9VO8zkO CkVI6sxCSGNknayaUzy6n3bm_DN5L.CJh5zjT_zb4nYsKvQe44CTAPl2zcy_jhuR4zi6WEc0KU0L a.Hb15MMk0.SNEfwXjagBfLFBIPi77tl5E9STVqIlEn.aHIiL_9nwcBjAwRMPruiAJSmIjh4O2M8 f7UVvdmGm_epP8ftihDVPTJqwLkHGr3ul4iaSPmxmlpLXCpn7fPHzsnMN22dlpw1FD5xd7rzbpW. gjG0qljRg5hQZXXRiXAqcp90nRMFQ0YPcvyogiEVakkYYiIBT49QSLb9eBSFqD5fB7303eQrh8Qv xs8CU2uOEAlX_8YzoJ88FEx7OF4kcEsOgCP.rKTCVv X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Mon, 6 Dec 2021 04:41:40 +0000 Original-Received: by kubenode516.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 896d42fb5abbe55739f4fe2d4355b87b; Mon, 06 Dec 2021 04:41:35 +0000 (UTC) In-Reply-To: <87bl1upn3k.fsf@yahoo.com> (Po Lu's message of "Mon, 06 Dec 2021 08:56:47 +0800") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.206; envelope-from=luangruo@yahoo.com; helo=sonic310-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281047 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >> Thanks, I guess it is now up to the people who use(d) this branch: if >> they say it's in good shape, we are ready to land it on master. > > That's great news! The child frame feature on that branch is totally broken. Evaluting the following code is enough to make it emit tens of GLib warning messages (the product of use-after-frees) and eventually crash: (make-frame `((parent-frame . ,(selected-frame)))) Most of the code in gtkutil and pgtkterm is also unprepared to deal with frames that don't have an outer widget, which is the case with pgtk child frames. That code will have to be carefully reviewed and reworked. Needless to say, unparenting child frames or reparenting child frames to another frame is even more hopeless. I plan to rework that feature. Before that, please do not merge the pgtk branch.