From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Jai Flack <jflack@disroot.org>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: gnus-search-mu
Date: Fri, 25 Mar 2022 15:46:19 -0700 [thread overview]
Message-ID: <8735j5tzus.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87sfr6eunp.fsf@disroot.org> (Jai Flack's message of "Fri, 25 Mar 2022 10:35:22 +1000")
Jai Flack <jflack@disroot.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>> Hi! Thanks very much for working on this. Wouldn't it make more sense to
>> include this in Emacs proper? Gnus-search is new enough that it doesn't
>> seem useful to let users of prior Emacs versions to install
>> gnus-search-mu from the repos... What do you think?
>
> I'm happy for it to be included in Emacs proper; though possibly as both
> a la modus-themes as it's missed the release window for Emacs 28 (if I
> understand the release cycle correctly).
>
> Shall I convert this to a patch for gnus-search.el?
Sure! Thanks.
Please note that engine custom options like -remove-prefix and
-config-directory have been moved away from `getenv' to something like:
(expand-file-name "foo" "~")
and it would be nice to stick to that convention.
Otherwise, please make sure that the first line of docstrings are a
complete sentence, and there's no need for a blank line between the
first sentence and whatever comes after.
Out of curiosity, what is `ansi-color-filter-apply' doing there?
Yours,
Eric
next prev parent reply other threads:[~2022-03-25 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:17 [ELPA] New package: gnus-search-mu Jai Flack
2022-03-24 15:18 ` Eric Abrahamsen
2022-03-25 0:35 ` Jai Flack
2022-03-25 22:46 ` Eric Abrahamsen [this message]
2022-03-27 4:12 ` Jai Flack
2022-03-27 20:26 ` Eric Abrahamsen
2022-03-27 23:43 ` Jai Flack
2022-03-28 3:57 ` Eric Abrahamsen
2022-03-28 8:22 ` Jai Flack
2022-03-29 20:28 ` Eric Abrahamsen
2022-03-30 4:42 ` Jai Flack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735j5tzus.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=jflack@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).