unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 5b5608c614: Fix glyph skipping optimization when a tab line is enabled
Date: Mon, 18 Apr 2022 15:53:47 +0800	[thread overview]
Message-ID: <8735iaket0.fsf@yahoo.com> (raw)
In-Reply-To: <83ilr6x2gx.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Apr 2022 10:41:50 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> OK, and what about the last question I asked above?  If there's no
> header-line, but there is a tab-line, the code will still compare vpos
> with 1, although the vpos of the tab-line is now zero, right?

I see how the code might be made clearer if the assumption that a mode
line cannot be at vpos 1 isn't made, but can a mode line (the other kind
of mode_line_p row there is) really be at vpos 1?  Aren't windows
required to have a body height of at least 1 line?

Thanks.



  reply	other threads:[~2022-04-18  7:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18  7:18 master 5b5608c614: Fix glyph skipping optimization when a tab line is enabled Eli Zaretskii
2022-04-18  7:32 ` Po Lu
2022-04-18  7:41   ` Eli Zaretskii
2022-04-18  7:53     ` Po Lu [this message]
2022-04-18  8:17       ` Eli Zaretskii
2022-04-18  8:23         ` Po Lu
2022-04-18  9:18           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735iaket0.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).