From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [External] : [emacs bookmark.el] Sorting by last set Date: Fri, 27 May 2022 15:20:49 +0200 Message-ID: <8735gv6rim.fsf@gnus.org> References: <877d6b88pz.fsf@elite.giraud> <875ylv6j58.fsf@elite.giraud> <87o7zngcgf.fsf@gnus.org> <87k0a93g4z.fsf@elite.giraud> <87y1yp1vnw.fsf@elite.giraud> <877d69lyt2.fsf@red-bean.com> <87ilpsd0hv.fsf@gnus.org> <87tu9c1c0k.fsf@elite.giraud> <87leuo12fh.fsf@elite.giraud> <87zgj38ds1.fsf@gnus.org> <875ylr15nm.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14035"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , Karl Fogel , Drew Adams , emacs-devel To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 27 15:22:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuZuo-0003PU-U0 for ged-emacs-devel@m.gmane-mx.org; Fri, 27 May 2022 15:22:07 +0200 Original-Received: from localhost ([::1]:56140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuZun-0001tc-CA for ged-emacs-devel@m.gmane-mx.org; Fri, 27 May 2022 09:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuZtn-00012C-NT for emacs-devel@gnu.org; Fri, 27 May 2022 09:21:05 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuZtl-000237-89 for emacs-devel@gnu.org; Fri, 27 May 2022 09:21:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7Jf4Xg8166kqy59vitO6Zq9KmvtkF002Vj55k2nUs/k=; b=uM+5nT41StiOANG8mhP/sN1kA/ Z2uDXvq5KoJb8omSmLc2Q9zA+lbj91cjanREDFsfho4ZroJuLTBoQildl/qmchWSAfob1Fozur5sZ +jA+xZgfDRAmZLaTTjx5lyj/7pGEhPA6NuSkYt2ABNV9NEy2wiS+VjKUMlX2rToBVPok=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuZta-0008Lh-T3; Fri, 27 May 2022 15:20:53 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEW2wpmtuJSfoXWN dXgZGB5XU1XHxrT////kBx3DAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YFGA4RI6qk3VcAAAGoSURB VDjLjZRLboMwEIZniJT1DKhdYyfdl7hcoLH3UbD3qAvuf4SOMQZDq6q/EqL487xtAJKYCZALyRqh fPioCKAUJXsByKh0kjEXZmMMzYC5spvu8U8bAUnQAjxxBVCCO7wkMMcrwPvJJ4B74ODDZlc7cB9f /K/A1VBtAIsY0pjrCrhyQRR92KHDyi8AER1PU++TM2qvmyv3Op2X9RtzaUEzGJgm4A97tHiOEzdm Tjc1GqsZfI5NCCm3NvWfE3igz0kvFpBAC2/BhwOIwR9wns5fg/9h4RhpbMc3MWqpBDYEY1iPoP0C JKtzLjAMRhESZwAZxOKHbuk6RAB+a/E6j5jVfwHhXxZ4iHHTtIy8AC48WfdyxjdX83onzi+9tKQI bq1WpPhiUksK8JA7YtLkW4b57CbQqsb0+zpOckrAKr0m9l4W6Kr618pRUkEddoAjIOvMjcDk0caJ 4CkXOHR0ifFzuigTaPoQehlTV/sQZHsCdVg1qKoxGfwULl1EpsOOCBa7eHvlZqf9IBtR1axqSYPl d/5qedYcXxssrmD/iqkpuYteDkG+AXZJoFfktC8XAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1 LTI0VDE0OjE3OjM1KzAwOjAwvhiZlQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0yNFQxNDox NzozNSswMDowMM9FISkAAAAASUVORK5CYII= X-Now-Playing: Porridge Radio's _Waterslide, Diving Board, Ladder To The Sky_: "I Hope She's Okay 2" In-Reply-To: <875ylr15nm.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 27 May 2022 15:11:57 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290313 Archived-At: Manuel Giraud writes: > With the patch a call to (bookmark-make-record) will have an up to date > last-modified field so it cannot be equal to a static bookmark record. > For the same reason, two successive calls won't be equal. Should I try > to fix those tests or fix my code? Sounds like fixing the tests is the right thing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no