From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling. Date: Sun, 24 Jul 2022 14:10:33 +0200 Message-ID: <8735eqaeyu.fsf@gmail.com> References: <165799889678.19490.7919197387382513250@vcs2.savannah.gnu.org> <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org> <87o7xgcb0a.fsf@tcd.ie> <83fsishsnb.fsf@gnu.org> <87mtd0aqea.fsf@tcd.ie> <878roiahki.fsf@gmail.com> <831quahgze.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, emacs-devel@gnu.org, gregory@heytings.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 24 14:11:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFaSS-0002Ek-ER for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jul 2022 14:11:40 +0200 Original-Received: from localhost ([::1]:47850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFaSR-0000Sg-EW for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jul 2022 08:11:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFaRT-00086x-P1 for emacs-devel@gnu.org; Sun, 24 Jul 2022 08:10:39 -0400 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:39510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFaRR-0006W0-Ci; Sun, 24 Jul 2022 08:10:38 -0400 Original-Received: by mail-wm1-x32f.google.com with SMTP id i205-20020a1c3bd6000000b003a2fa488efdso1958886wma.4; Sun, 24 Jul 2022 05:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc; bh=rkw6iN/ScYAS6vOJM0nZRffqSAMNZW4ONZG0gjSMqbQ=; b=kRuQvIJbjEGnjkSxle7vmLTLSv9KTBLMet6kaRXPUTf4nbqQmd9CJYf+aonwh48wNZ uOxCgeWX636HTnkRaJgeRJA4dDMg5mbO88kyMDmpJiItuoxRL0GwtJhg17Gq13K4FW0S RS/oNnuWlVaejlcXHmDw2eXLpBACNSvmHNT753efCjTBc25vP6WMnTNG6W3moS0dIOAq FdeIEOU09nxVUoBuA+JQ6fTJEResKmWTBnXUla0wUvbZOPSf7hdSH5xb0+1/nSMlgdU1 IGvL2AnhFd1crsDab/C1uJZztMPA2Q5h9+KD5ryGw8BgGpCOQcB9UEDzD2J9nQ9aahdD Jmvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=rkw6iN/ScYAS6vOJM0nZRffqSAMNZW4ONZG0gjSMqbQ=; b=TjlyLjVfSfJIrZcTq8CNBcwexhDo93g4Q8cjuyzsmfolR/gRMrsWqw1uu8bktTIJAT ZYSIUz0gMxolfuX89x3MdsG8+ujHBC8qCl63+VFqK7m/y/DcD5g5+3nTCTwRpsVZ1gkk 7F+Dcuh1RMJutG0/vWUWH32YcDJnK8LGRt/zEhdWkN0E4nFWjz1jh3ASIo/guoH/w/Zz Rt/OTVz+idlibcw1MW+VANjh247jBWB27vj1peYvdmCcP99cQ1xkyv4YE465kDMEgS0L Wm4h+TUNKNHPx2QV10bV7eTZeDRmX8+FgLULFqU5Bcaumw2ceVdynf1LgSoo9EV1EMJG TNNQ== X-Gm-Message-State: AJIora+R10YyA/VLr6tDHa0mMabSSkYLSImuIuQPjsCFgf2uma05mNJk F5IApgDp3CUlscylJnxIL5E= X-Google-Smtp-Source: AGRyM1uEs57P86SN7Rc/crGVMY1waAJuXFc+yNQjOtTO5NBSF6RAXnw3ddJBgJGoLCwQ1AW/uIMW2A== X-Received: by 2002:a05:600c:3510:b0:3a3:34e7:cfc8 with SMTP id h16-20020a05600c351000b003a334e7cfc8mr11871819wmq.164.1658664635404; Sun, 24 Jul 2022 05:10:35 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:80e6:4dab:1d1f:d225]) by smtp.gmail.com with ESMTPSA id s2-20020a7bc382000000b003a3253b705dsm10838355wmj.35.2022.07.24.05.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 05:10:34 -0700 (PDT) In-Reply-To: <831quahgze.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jul 2022 14:45:09 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292580 Archived-At: >>>>> On Sun, 24 Jul 2022 14:45:09 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii , emacs-devel@gnu.org, gregory@hey= tings.org >> Gmane-Reply-To-List: yes >> Date: Sun, 24 Jul 2022 13:14:21 +0200 >>=20 >> Apropos, is there an =CA=BCupdating pdumper stuff for dummies=CA=BC = guide >> somewhere? Something along the lines of: >> - if you add an int to struct , do >> - if you add a Lisp_Object to struct , do >>=20 >> I ask, because I=CA=BCm playing with struct buffer_text, and I=CA=BC= m very >> successfully causing 'failure to dump' :-) Eli> The error message points you to the comment in config.h that is Eli> supposed to be the "updating pdumper stuff for dummies" guide: Eli> error: #error "buffer changed. See CHECK_STRUCTS comment in conf= ig.h." Sorry, I wasn=CA=BCt clear. That just fixes the compile error, it doesn=CA= =BCt cover the second part, which is to ensure that your new field is dumped/restored correctly. For a struct Lisp_Hash_Table *, DUMP_FIELD_COPY is not enough. Robert --=20