From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 088171e053 1/2: Fix ns-win.el (x-file-dialog) declaration Date: Fri, 19 Aug 2022 19:58:36 +0800 Message-ID: <8735dso36b.fsf@yahoo.com> References: <166090717426.4526.7562850425788954733@vcs2.savannah.gnu.org> <20220819110614.BB982C04F0E@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38333"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 19 13:59:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oP0ew-0009q5-PZ for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Aug 2022 13:59:30 +0200 Original-Received: from localhost ([::1]:40798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oP0ev-0005E9-T4 for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Aug 2022 07:59:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oP0eH-0004XH-Ha for emacs-devel@gnu.org; Fri, 19 Aug 2022 07:58:49 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:36905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oP0eF-0002TM-NY for emacs-devel@gnu.org; Fri, 19 Aug 2022 07:58:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660910324; bh=JP079R1jNftPW6NjAu5/ZcKd+cT7UDN1L4bhVws415E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ioqEdQT0D0sdhbS6gjpavEVv1e0MCEqGKiM++s0BtdyA2PABmIEPj2Zd2pyML17E24Y1HlkBoVJAMYpur2KDZoNoWFYWWKxVPrbqpLPXroc+53vjHDBOOYj8X9qpuJPxZFdofyrVYk+bp2YSi802/G9ZKpYmAk50sFLfAhud63YVdNvn8l+HHxKm25UHpNKyKr0Q6GU1ai5m1DefYOi/uIxQusSALFL+EFFRpiFh6CjPGqLz3UrVPnrL97A75ZszoockI0B1Aal5N7qc3FYiar5dSefQ1/NW5i2qfTy3jPiRgaBTPW1ovxcs2qzdcF9/77l+I9XriFL6piifjkf7YQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660910324; bh=dNCKYkZ2DTkdaRcPzhPLW52m76zhczjPCJmEYnirRh4=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=lyJ1HtbKMEsyfP8GdvFX/XSKWio8dXVJxjA2XTJje47gXYulfi+LNDdT1ASu3iASneu0NHs73SXL+kpBnL2OfvJdm/P8DcOYL0Iv8MLRFPGzO93Smr80OGnVkiD2dHna/I9fPhUo4TRC/akILKrVWSH5TXeJSvy22thfAs8ECcw7O4AjSa1Z+opaz2RsYG4krS7fyPJPE6xVZdOTf37FDHWjUwwbInHzjqwXYdt9ASvt/lCBT1lsNfoaV7tMj7UHGlTVAmNMlZZfPN0azk8vwoAAlzcpjn4K6J8juuPNG42AZnkJAeesfBl2xy3RLX0Lu+Aup3HPt2V2+YnaHBFojw== X-YMail-OSG: TuYOIEkVM1nGXGcTPdhxzo3yYPe5eILI9chtarcF0r4cRz0JYuxOgMjJrUT5b2B ZQuC2XpE2EsSdfjpaB426UcIcCQmLJLAjTiGIn8trG89gVIpVu7gX64YxLp0m7WxPZ3Hapt2v99k x6YpbYKtKpasCyCf0ytED1Jh39IENilb4EJZPW.eL_SsxWIS6wRj7yFbqBpUmE4VAjrJASsafgZX _zxzU.5gGNyhKY_25nbBez34cMaPi1NUWNGZm11sFf6BmTA6crkq.nGbHczphNs6CWDRieyrHTMx 5KPt08h.i8tbsaPzQd_fRVJH1Ts3ZAU3QhrLFdrOy.ae32_xUVexM6Se.U_fxmW5nc0Akw10Snpt 0NFJ2oEeXQ7t8dYRyc9Pabf_E6Ogj9kU9QSehFATGvBd5SdR2se7c8C4ewWljJ6J_xHDQExWSq7d UToOigB_UwwfHBsrNY6k2Q0WTDWceDjbW8bEse2_CKLN9ZBczMtE0lWpZknpU8.jBzrMWxhXIxRV WvA.vRE2aoOXq659O8HJL.xhU04PspdwLqW6oC9C0FH8PBQJd94xwi4iE92223H8EBnNPKFbH23X 5ZTPaIN3z22T9TYsjUzuivIt35OuJWbMjXUB4LoApwSHUjU6WxeU6gKz63lV_plWnVwCM1fdoTI. HOixFZ4vBvrbhx7uHQi2yxYLVzAV_LEd1kVR.YU_Ye2LBF57SOctBay0zblFpSU.bmm4hcSsDz_V RXX8gsseipJIxcsbzwE29xaQAgX9tosVt9NJWOoyojH0FWafGbyMagEqUaP9dD2mSevFepF7GpWG gukoTxKw3diO.LUzbrGyR70mEPDoDx8A95SzbbqgnC X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Fri, 19 Aug 2022 11:58:44 +0000 Original-Received: by hermes--canary-production-sg3-6f58cd9b5-jq7xs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1fb7fda97c5970a0dc3ea2a52c9e583f; Fri, 19 Aug 2022 11:58:41 +0000 (UTC) In-Reply-To: <20220819110614.BB982C04F0E@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 19 Aug 2022 07:06:14 -0400 (EDT)") X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293629 Archived-At: Lars Ingebrigtsen writes: > branch: master > commit 088171e05316c9188186a731f3c7e68c103c4e0a > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > > Fix ns-win.el (x-file-dialog) declaration > > * lisp/term/ns-win.el (x-file-dialog): Give the function the same > signature here as other definitions. > --- > lisp/term/ns-win.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el > index e26191b33b..56aca2bd83 100644 > --- a/lisp/term/ns-win.el > +++ b/lisp/term/ns-win.el > @@ -439,7 +439,8 @@ Lines are highlighted according to `ns-input-line'." > > ;;;; File handling. > > -(defun x-file-dialog (prompt dir default_filename mustmatch only_dir_p) > +(defun x-file-dialog (prompt dir &optional default_filename > + mustmatch only_dir_p) > "SKIP: real doc in xfns.c." > (ns-read-file-name prompt dir mustmatch default_filename only_dir_p)) > I guess it would be good to change the function arguments names too to avoid the underscores.