From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.devel Subject: Re: noverlay branch Date: Sat, 08 Oct 2022 20:23:58 -0700 Message-ID: <8735bx65o1.fsf@rfc20.org> References: <83pmfill6l.fsf@gnu.org> <87illaffm5.fsf@localhost> <838rm6ktxp.fsf@gnu.org> <87v8ovdosz.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27536"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Ihor Radchenko , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 09 05:24:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohMvl-00070S-RH for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Oct 2022 05:24:45 +0200 Original-Received: from localhost ([::1]:55376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohMvj-0002pT-Pi for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 23:24:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohMvA-00028l-7L for emacs-devel@gnu.org; Sat, 08 Oct 2022 23:24:08 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohMv7-0006bF-Vg; Sat, 08 Oct 2022 23:24:07 -0400 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id C764460002; Sun, 9 Oct 2022 03:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1665285842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f5SUwLbDXpzI+XR7UTzu5SRQ5tVCGsKK1RJNHMRy9Dg=; b=ObjLg6+3/M+2n+r+YrXdBX0D6tu0l0Mn9JXr6ZAvjctR+UY7Fcx6pP8v/0aDiBXghjqB08 EadPnsfuCxLVAQo2V6y9RyN/pEsZD+4o8XdncXsR1DXlItxnUCOUWu2/tCZ+v8YOA0KEQf b+FpoRKGGNqlxc9xebMmboLECITnOAOhGGT3UdVdKxN1MbGFDMfU70bn+pVX58aWHPjSlW FZlilfHdGd3i2noXJbu2CiG4DmeERieK7Szdb9KmaI63ceVx5u7YH29fVp0PkBREaVFJ4P BsQtg52NLYvvADzU8jOmTHv/uAQDlC1gFUx5++hMrRrmiJiDeMiXYJRq/dci/Q== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1ohMv0-005DIV-0m; Sat, 08 Oct 2022 20:23:58 -0700 In-Reply-To: <87v8ovdosz.fsf@localhost> Received-SPF: pass client-ip=217.70.183.195; envelope-from=matt@rfc20.org; helo=relay3-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297233 Archived-At: Ihor Radchenko writes: > Update: I can no longer see crashes on the latest commit in the branch. > > I was able to use the branch with my config for while now, and it works > mostly fine. > > There are a couple of glitches though: > 1. hl-line-mode overlay sometimes disappear > 2. notmuch search buffer hides text in wrong places (see the attached video) > > Should I report these things as proper bugs or is it OK to discuss them > within this thread? Hi Ihor, yes, your glitches (1) and (2) make sense to me, given some fundamental bugs I have uncovered in noverlay branch. In some not-yet-commited debug code I have against the noverlay branch I am seeing binary tree invariants violated. For example, overlay nodes in a binary tree with BEGIN positions that are out of range for the subtree they are in, potentially caused by them being offset incorrectly. The algorithms involved are quite fragile. These bugs would cause functions like overlays-at and overlays-in to potentially miss overlays, as well as for BEGIN and/or END to be in incorrect positions. This would explain both scenarios you describe above. Polishing off this new debug code and getting it commited, as well as fixing the bugs, is what I'm working on.