From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Why 'define-package' marked obsolete? Date: Tue, 21 Mar 2023 09:36:07 +0000 Message-ID: <87355y78fs.fsf@posteo.net> References: <83zg87739o.fsf@gnu.org> <87jzzbp6bn.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 10:36:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peYPc-0007LP-El for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 10:36:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peYPL-0005Gp-9e; Tue, 21 Mar 2023 05:35:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peYPH-0005GO-9D for emacs-devel@gnu.org; Tue, 21 Mar 2023 05:35:51 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peYPF-0005y4-9i for emacs-devel@gnu.org; Tue, 21 Mar 2023 05:35:51 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4D2C024038B for ; Tue, 21 Mar 2023 10:35:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679391347; bh=99bFYuOurcem2Tc53ji/x9DUiq4usxgqsB2MvPG91N0=; h=From:To:Cc:Subject:Date:From; b=bN1fPtZBbKTcb4NHBRHg0D9yMcpnQ3Ca8UMQ2vVHpkUtgRWxdOKx47rzMTSpcwJIk l1ue6Bl1g7racvuIdEVT6pN2VNOSbNHibodd3AMCPII4vMMZftbUwNam0lRrAehpea kjfUDzaphXcBPenxxxqadpuqWCKnhGlB6YDLTdt74kP6bsOagPU/uGGTmNve9vVWDD KtwxsHGJ2aYJEfcd84s7N81dfwfD8DvDf9LEGwzAmhBceTGDdG4tX1QEUKa78gfuos 1BxilsquY6ZsrPc/G+O53QFx13qNvwGMnblkPwudJjxn1ETe038y0JlVN4V078i6/i eqlWfnB2BdiJw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PgmgP6HPhz6trH; Tue, 21 Mar 2023 10:35:43 +0100 (CET) In-Reply-To: (dalanicolai@gmail.com's message of "Tue, 21 Mar 2023 10:10:02 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304634 Archived-At: dalanicolai writes: > Ah okay, I see. > > So I assume that this means that as a function 'define-package' was > redundant, but we should still include a 'define-package' in the > -pkg.el file of a multi file package? No, the -pkg.el file is generated by ELPA using the information from the main file. There is no need to write it yourself, in fact it is a waste effort since it will be overwritten anyway. Package-vc does the same btw. > The initial comment of 'package.el' mentions that the -pkg.el file > should consist of 'a call to' define-package. I would say this > formulation is somewhat confusing/misleading then? You are right, that comment is outdated and should be revised. > Or is the -pkg.el file just outdated? And did I miss the news about it? No, the file is still required because it contains the package descriptor. The only thing that changed is that instead of the contents being evaluated as code, they are read in and processed manually. Without that file, you will notice that `package-load-descriptor' wouldn't add the package to `package-alist', which in turn means that `package--activate-all' wouldn't activate it. > On Mon, 20 Mar 2023 at 20:32, Philip Kaludercic wrote: > >> Eli Zaretskii writes: >> >> >> From: dalanicolai >> >> Date: Mon, 20 Mar 2023 17:21:04 +0100 >> >> >> >> Can I ask why 'define-package' was marked obsolete? >> > >> > It never did anything useful. Its original implementation just >> > signaled an error. >> >> I just looked up the definition from when package.el was merged[0], and it >> did stuff, mainly modifying `package-alist'. >> >> [0] >> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/emacs-lisp/package.el?id=44198b6ee97bcb0ac88a5cadd1bf9b62048d0156#n513 >> >> -- >> Philip Kaludercic >>