From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Adding some convenience functions to color.el Date: Fri, 09 Jun 2023 06:22:03 +0000 Message-ID: <873531updg.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6350"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Yilkal Argaw Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 09 08:23:10 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7VWg-0001R5-De for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Jun 2023 08:23:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7VVl-00033E-BQ; Fri, 09 Jun 2023 02:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7VVi-00032x-GC for emacs-devel@gnu.org; Fri, 09 Jun 2023 02:22:10 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7VVg-0004xw-5y for emacs-devel@gnu.org; Fri, 09 Jun 2023 02:22:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 44C6D24002A for ; Fri, 9 Jun 2023 08:22:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686291725; bh=CN1eQlf3UzDqgNGAkZeTizvpFYU/XYdRgDiTqLYDN58=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=iXSaXIGgYvCsbp2ABhLKjH+6OpZQLx83jcd0ZyD0kv6jdCjmoTkK8ttBZj+jfaQMQ g0WrEoAW4XUnTWPuhHcgd5yTI6EQXsSZ/LlrSESsXYAXkp4Ro9mL1KYISS74hWh9+b cKZlpGefOvy8ncz69Yd9xOUzqPhKEtZlXFbXdvzEcrxTTKYVX0SEm7xVBofbG+x+XC SCN8ylKBeSZgoMPS99DLThVmH+uwV0oTMMm8wn9B+t9jITufRgo4T0RxIBrkNcGmVo lM57i8A5kHFHgnos844PT8gYXJVFTjQhEG7hYnaBbrHTUbhUV1uPenj8d2ujjmn2Kj oWwTrERscK4zQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qcrb05Z41z6txB; Fri, 9 Jun 2023 08:22:04 +0200 (CEST) In-Reply-To: (Yilkal Argaw's message of "Fri, 9 Jun 2023 02:57:41 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306704 Archived-At: Yilkal Argaw writes: > Hi > Today I was messing around with some theme that made use of color.el and I > noticed some functions that might be of use could be added to color.el to > help with the conditionally assigning setting some colors based on > lightness or darkness of some other color. I wondered if it might be useful > to other users and if it might be worth adding it to color.el. I > > diff --git a/lisp/color.el b/lisp/color.el > index f68cf5e6b17..3740c3d5a7c 100644 > --- a/lisp/color.el > +++ b/lisp/color.el > @@ -119,6 +119,18 @@ inclusive." > (color-hue-to-rgb m1 m2 H) > (color-hue-to-rgb m1 m2 (mod (- H (/ 3.0)) 1)))))) > > +(defun color-name-to-hsl (color) > + "Convert COLOR to HSL." I think it would make sense to mention what COLOR is. Or at least call it COLOR-NAME. > + (apply #'color-rgb-to-hsl (color-name-to-rgb color))) > + > +(defun color-name-light-p (color) > + "Return non-nil if COLOR is on the lighter side." > + (when color (>= (caddr (color-name-to-hsl color) 0.5)))) IMO using `and' is better if you are interested the return value of an expression, while `when' is usually more indicative of a side-effect (on my first reading of this assumption had me confused to the point of the function). But setting that aside, why should someone pass nil to this function? > + > +(defun color-name-dark-p (color) > + "Return non-nil if COLOR is on the darker side." > + (when color (not (color-name-light-p color)))) > + > (defun color-complement-hex (color) > "Return the color that is the complement of COLOR, in hexadecimal > format." > (apply 'color-rgb-to-hex (color-complement color))) This is useful! Could you prepare a patch and update etc/NEWS? It seems that the other color functions are not documented in the Emacs Lisp manual. > > With Regards > Yilkal Argaw