From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: bug#64023: 29.0.91; gnus-icalendar does not update timestamp when description is empty Date: Tue, 13 Jun 2023 14:51:19 +0200 Message-ID: <87352vh6ew.fsf_-_@gmail.com> References: <87jzw8hcrp.fsf@gmail.com> <87bkhjhc3v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel" To: Reindert-Jan Ekker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 13 14:51:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q93Ux-0001ge-7P for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Jun 2023 14:51:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q93Uc-0000vw-QR; Tue, 13 Jun 2023 08:51:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q93Ua-0000v5-HB for emacs-devel@gnu.org; Tue, 13 Jun 2023 08:51:24 -0400 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q93UZ-0002Na-32 for emacs-devel@gnu.org; Tue, 13 Jun 2023 08:51:24 -0400 Original-Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f8d17639feso4504725e9.2 for ; Tue, 13 Jun 2023 05:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686660681; x=1689252681; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=My0uy1bCsSqRXV8y6wFGHn9cJ/4jkbBJRFi0uBl5T88=; b=cjeZ2CjPfrrtosoImYVLNjrlW4MRTVBvfFBPl9OV2Xs263StZrziiFdzN7MePJCMzW XXhFoNZWK60wg4YzCTZw0uIoTw7EV5HbUS+UawNX9n8+6JTBnfgW2fCFDLlUSS4TuK93 TjvuYSKx8WX4R0KN8+DhW4TERldpuxLDOUpeDu6KnHEpIn8Cd4y2MitH7oh4owX2zIsE tzgy9gPiBvv0Gnga26Q/70WsfZQHSzLAY+kFzhwlyRyXU0C63K9jJdvblOSPEgAW5OUu m9ed2P2IWxb8Iu+JalwJC4yO0rNR+RjF0t20FE5gCTXwbcG9NtUMvIwqh6TsDvUgQmLP hwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686660681; x=1689252681; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=My0uy1bCsSqRXV8y6wFGHn9cJ/4jkbBJRFi0uBl5T88=; b=J0qmh3M1H631e9weGKW0WsWZqNaovtCWdxdmHzasfZHv+U3YmeRn2OfsXYmOJieGPK SYUpwCwnuMnqHp3cYHEo3bWMUsAX7/UvYQjDS/u9JtDMZtAKPnEs3mLVwERrbmIKf/9K iQlU/9sh3d+5ngq67exMd369PvSS/P9he8e9L/C2Qn9SquZehSDYhAKQtN9XG4NzFEXX 9NHUWnITAZbSAYGXX2d+hSmgi/PRLCM/j0UAvHlHvKIsfoNalSBkKomtm9fgMt2VYzlU P7FZv0GYTi1UvZFhqOc5qDoOC/FMGJQVzT2mDXNqi2hO2y51WtzgagcJiHYZJ8MBNoIR ZNfw== X-Gm-Message-State: AC+VfDydStKNVucqVWLDt5HKvGkkF/ebV0cqiJgf/DmX4ng/7CKREGeY jXsui36Knd89Ql1FxAqx205OmT4IEcY= X-Google-Smtp-Source: ACHHUZ5wmCdZzHhhGrzcK1luZxhr4LujcV74q/PSQJIzH60Co7ZyL3jvLW5cbYA+jph5fywQjFnLMw== X-Received: by 2002:adf:ee4d:0:b0:30f:bfa0:920b with SMTP id w13-20020adfee4d000000b0030fbfa0920bmr5044210wro.36.1686660680666; Tue, 13 Jun 2023 05:51:20 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id i1-20020a5d4381000000b0030c4d8930b1sm15244912wrq.91.2023.06.13.05.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 05:51:20 -0700 (PDT) In-Reply-To: (Reindert-Jan Ekker's message of "Tue, 13 Jun 2023 13:57:35 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306773 Archived-At: >>>>> On Tue, 13 Jun 2023 13:57:35 +0200, Reindert-Jan Ekker said: Reindert-Jan> By the way, what is the intended behaviour of Reindert-Jan> gnus-icalendar--cancel-org-event? It seems to search for = a property "DT" Reindert-Jan> that does not exist (at least in my files), so it does no= t change the Reindert-Jan> event. Is this a bug or am I missing some configuration s= omewhere? >>=20 >> It looks like a bug. I can=CA=BCt find any code creating such a prop= erty, >> the current code inserts the timestamp in the body of the org entry. >>=20 >> Robert Reindert-Jan> Do I need to send a new bug report for this? It would be nice to have a separate bug so we can track the change. Reindert-Jan> I would also like to try and write the fix for this, if y= ou don't mind. Reindert-Jan> I think the correct behaviour would be to completely remo= ve the entry Reindert-Jan> from the file - probably with a confirmation prompt. I never say no to other people writing patches =F0=9F=98=BA There=CA=BCs lo= ts of useful info in CONTRIBUTE in the emacs sources about code and commit message conventions. Reindert-Jan> Alternatively gnus-icalendar--update-org-event could upda= te the entry to Reindert-Jan> include the word "cancelled" in the summary and deactivat= e the Reindert-Jan> timestamp. Deactivating the timestamp is what the current code attempts to do, I think that=CA=BCs a less surprising change than removing the entry. Robert --=20