From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: ob-asymptote.el Date: Wed, 06 Sep 2023 22:08:56 +0000 Message-ID: <8734zreyyv.fsf@posteo.net> References: <87lefpgzdl.fsf@iki.fi> <87pm4qd7ly.fsf@iki.fi> <87lef195yy.fsf@iki.fi> <875y4oee8t.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="449"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jarmo Hurri , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 07 00:09:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qe0ih-000AUG-DD for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Sep 2023 00:09:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qe0hu-0001h1-Eu; Wed, 06 Sep 2023 18:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe0hq-0001gY-8S for emacs-devel@gnu.org; Wed, 06 Sep 2023 18:09:02 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe0hn-0008IQ-7d for emacs-devel@gnu.org; Wed, 06 Sep 2023 18:09:02 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D2107240027 for ; Thu, 7 Sep 2023 00:08:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694038136; bh=fgZCzTyIxEqSVOUlMUK8i8kl4ojkLMWBvT44R6S4ZT0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=flCllapym+tg9p9eYelQL0bTbnhlfVGSyKIzjaHN3sb/Wh58HdqhQ/d5JY+t3lFcr tZS0DRdl4wqQBjDlM8/R+CJ1UNqU+vt8DdokjtNR3ytN3IBgQn6bkAwpk1mQ2de+WC ySo5fKnwHJGjhphb7322JXdUFwP4TN7NWf3vBV7or6K0Ofn5nPwIJZ0SwqT+d4H4JT 3IXozpH4ZyYC66nkCrKi6KVLN4eCJJv6wKpZD/vjkDOlFTAJ3HvlW9oMQtR6wBAyoG dh+ZewL0jPxEpPHExll8FjzHPZZfnJSCRjqNYFlInZBG55S1505RYhnbueUfBrO8Sy GoV5UYZ7lrhEQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RgxNS2czyz6txF; Thu, 7 Sep 2023 00:08:56 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Wed, 6 Sep 2023 02:37:18 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310220 Archived-At: --=-=-= Content-Type: text/plain Stefan Kangas writes: > Stefan Kangas writes: > >> Philip Kaludercic writes: >> >>>> Is there anything blocking this package from going in? >>> >>> I don't think so, I am just confused why I appear to not find any >>> previous discussion on this in the archives. >> >> It was discussed previously here: >> https://lists.gnu.org/r/emacs-devel/2023-07/msg00339.html > > Do you think we could add it now? The requirements section mentioned that "asy-mode" is necessary, but there is no package for that. I guess that is a blocker, unless the information is outdated. Otherwise, I think a change like this would be nice to have: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/ob-asymptote.el b/ob-asymptote.el index de99ca3..a088fab 100644 --- a/ob-asymptote.el +++ b/ob-asymptote.el @@ -61,20 +61,19 @@ This function is called by `org-babel-execute-src-block'." "pdf")) (cmdline (cdr (assq :cmdline params))) (in-file (org-babel-temp-file "asymptote-")) - (cmd - (concat "asy " - (if out-file - (concat - "-globalwrite -f " format - " -o " (org-babel-process-file-name out-file)) - "-V") - " " cmdline - " " (org-babel-process-file-name in-file)))) + (cmd `("asy" + ,@(if out-file + `("-globalwrite" "-f" format + "-o" (org-babel-process-file-name out-file)) + "-V") + cmdline + (org-babel-process-file-name in-file)))) (with-temp-file in-file (insert (org-babel-expand-body:generic - body params - (org-babel-variable-assignments:asymptote params)))) - (message cmd) (shell-command cmd) + body params + (org-babel-variable-assignments:asymptote params)))) + (message (mapconcat #'shell-quote-argument cmd " ")) + (apply #'call-process "asy" nil nil cmd) ;should "asy" be a user option? nil)) ;; signal that output has already been written to file (defun org-babel-prep-session:asymptote (_session _params) --=-=-=--