unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Rahguzar <rahguzar@zohomail.eu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Albinus <michael.albinus@gmx.de>, emacs-devel@gnu.org
Subject: Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470)
Date: Sat, 20 Jan 2024 12:30:20 +0100	[thread overview]
Message-ID: <8734uss0jj.fsf@zohomail.eu> (raw)
In-Reply-To: <83a5p0til9.fsf@gnu.org>

Actually can be it be because `leim-list.el` needs to be updated with
call to `register-input-method` for the input methods in pakistan.el?

Rahguzar

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: Rahguzar <rahguzar@zohomail.eu>
>> Date: Fri, 19 Jan 2024 09:45:36 +0100
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > branch: master
>> > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6
>> > Author: Rahguzar <rahguzar@zohomail.eu>
>> > Commit: Eli Zaretskii <eliz@gnu.org>
>> >
>> >     Add input methods for Urdu, Pashto and Sindhi (bug#66470)
>>
>> This commit has added the following error in Emacs' tests:
>>
>> --8<---------------cut here---------------start------------->8---
>> # make -C test test-custom-deps
>> The following load problems appeared:
>> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan))
>> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan))
>> Test test-custom-deps backtrace:
>>   signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus
>>   ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro
>>   (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f
>>   (let (form-description-6) (if (not (unwind-protect (setq value-5 cus
>>   (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form-
>>   (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p
>>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>>   ert-run-test(#s(ert-test :name test-custom-deps :documentation nil :
>>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>>   command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el"
>>   command-line()
>>   normal-top-level()
>> Test test-custom-deps condition:
>>     (ert-test-failed
>>      ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value
>>       ((pakistan-urdu-input pakistan
>> 			    (file-missing "Cannot open load file"
>> 					  "No such file or directory"
>> 					  "pakistan"))
>>        (quail pakistan
>> 	      (file-missing "Cannot open load file"
>> 			    "No such file or directory" "pakistan")))))
>>    FAILED  1/1  test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35
>>
>> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec)
>>
>> 1 unexpected results:
>>    FAILED  test-custom-deps
>> --8<---------------cut here---------------end--------------->8---
>
> I tried to look into this.  It seems test-custom-deps runs
> cus-test-deps and then requires that cus-test-deps-errors is nil.  I
> therefore ran cus-test-deps interactively, and looked at
> cus-test-deps-errors.  It is not nil, but its value is
>
>   ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No
> such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J
> (file-missing "Cannot open load file" "No such file or directory" "ob-J")))
>
> which doesn't mention pakistan at all.
>
> So I'm unsure how to proceed.  It would be useful to see the value of
> cus-test-deps-errors in the test that fails, or maybe I'm missing
> something in how this test should be run interactively.
>
> P.S. My guess is that some autoload is missing from pakistan.el, but
> without reproducing the problem I cannot verify that and cannot test a
> solution, and the error message from the failing test is not helpful,
> as it doesn't divulge the important details.



  parent reply	other threads:[~2024-01-20 11:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170030013667.20571.18090141972402319489@vcs2.savannah.gnu.org>
     [not found] ` <20231118093537.9F147C0C994@vcs2.savannah.gnu.org>
2024-01-19  8:45   ` master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470) Michael Albinus
2024-01-19 20:59     ` Rahguzar
2024-01-20 10:17     ` Eli Zaretskii
2024-01-20 11:16       ` Rahguzar
2024-01-20 11:30       ` Rahguzar [this message]
2024-01-20 11:58         ` Eli Zaretskii
2024-01-20 12:12           ` Rahguzar
2024-01-21 11:19       ` Michael Albinus
2024-01-21 12:34         ` Rahguzar
2024-01-21 13:21           ` Michael Albinus
2024-01-21 14:35             ` Rahguzar
2024-01-21 15:07               ` Rahguzar
2024-01-21 18:16                 ` Michael Albinus
2024-01-22  5:10                   ` Visuwesh
2024-01-22  8:24                     ` Michael Albinus
2024-01-23 17:30                   ` Eli Zaretskii
2024-01-23 18:25                     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734uss0jj.fsf@zohomail.eu \
    --to=rahguzar@zohomail.eu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).