From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom) Date: Sun, 28 Apr 2024 16:53:25 -0700 Message-ID: <8734r5avt6.fsf@ericabrahamsen.net> References: <171389641522.15334.4055859790974801392@vcs2.savannah.gnu.org> <20240423182018.97FA3C12C33@vcs2.savannah.gnu.org> <87a5ldn4fu.fsf@gmx.de> <871q6p2z5r.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:EkKkFn/J+uFosOukGUSJ7kTw1CI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 29 07:47:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1JrU-0006Ib-R0 for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Apr 2024 07:47:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1Jqw-0003rW-Kq; Mon, 29 Apr 2024 01:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1EKv-00020Q-OH for emacs-devel@gnu.org; Sun, 28 Apr 2024 19:53:37 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1EKu-0004ZW-62 for emacs-devel@gnu.org; Sun, 28 Apr 2024 19:53:37 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1s1EKr-0007OA-GX for emacs-devel@gnu.org; Mon, 29 Apr 2024 01:53:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 29 Apr 2024 01:46:44 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318309 Archived-At: Eric Abrahamsen writes: > On 04/28/24 12:53 PM, Michael Albinus wrote: >> Eric Abrahamsen writes: >> >> Hi, >> >>> branch: master >>> commit 1601c5a518dfa208af4827c56cf9570f3b90e15d >>> Author: Daniel Semyonov >>> Commit: Eric Abrahamsen >>> >>> Gnus: Add back end for Atom feeds (nnatom) >>> >>> * lisp/gnus/gnus.el (gnus-valid-select-methods): Add entry for nnatom. >>> * lisp/gnus/nnfeed.el: New file implementing an abstract web feed back >>> end. >>> * lisp/gnus/nnatom.el: New file implementing a back end for Atom feeds. >>> * doc/misc/gnus.texi (Browsing the Web, Back End Interface): >>> * etc/NEWS (Gnus): Document nnatom and nnfeed. >>> --- >>> doc/misc/gnus.texi | 77 ++++++ >>> etc/NEWS | 10 + >>> lisp/gnus/gnus.el | 1 + >>> lisp/gnus/nnatom.el | 276 +++++++++++++++++++++ >>> lisp/gnus/nnfeed.el | 683 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 5 files changed, 1047 insertions(+) >> >> This fails the tests: >> >> # make -C test test-custom-opts > > Thanks, we were missing a "category" definition in the new option > default, fixing now. This is still failing the tests, and I can't see why, I suspect the reason is in the "... ..." below: Test check-for-wrong-custom-opts condition: (ert-test-failed ((should (null (cus-test-opts t))) :form (null ((gnus-valid-select-methods :type-error ... ...))) :value nil)) FAILED 1/1 check-for-wrong-custom-opts (13.744560 sec) at misc/test-custom-opts.el:33 I've edited test-custom-opts.el to let-bind `ert-batch-print-level/length' to nil around the (cus-test-opts t) call, but that doesn't change anything -- can anyone tell me how to expand the output there? Thanks, Eric