unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 003eddc1dc3: ; Avoid byte-compiler warning in todo-mode.el
Date: Tue, 21 May 2024 15:05:51 +0200	[thread overview]
Message-ID: <8734qbe2mo.fsf@gmx.net> (raw)
In-Reply-To: <20240521111759.62ACEC1FB67@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Tue, 21 May 2024 07:17:59 -0400 (EDT)")

On Tue, 21 May 2024 07:17:59 -0400 (EDT) Eli Zaretskii <eliz@gnu.org> wrote:

> branch: master
> commit 003eddc1dc31a8b3c8ab2c0d7a8d05dcb83487b2
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>     ; Avoid byte-compiler warning in todo-mode.el
>
>     * lisp/calendar/todo-mode.el (todo-insert-item--next-param): Move
>     to after the definition of 'todo-mode-map', which this function
>     uses.  This avoids byte-compiler warning.

Oops, sorry about that.  However, because I try to keep the definitions
in todo-mode.el grouped into units of related code that is conveniently
displayed and navigated with outline-minor-mode, I prefer to pacify the
byte-compiler by defvar'ing todo-mode-map (without a value) before the
function instead of moving the latter, so I've done that in commit
c8b34046d93 (this time after testing not only that it works but also
satifies the byte compiler!).

Steve Berman



           reply	other threads:[~2024-05-21 13:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20240521111759.62ACEC1FB67@vcs2.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734qbe2mo.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).