* Re: master f896c5e8cab: ; Fix coding style of last change [not found] ` <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org> @ 2024-06-09 11:53 ` Stefan Kangas 2024-06-09 11:59 ` Po Lu 2024-06-11 15:05 ` Richard Stallman 0 siblings, 2 replies; 3+ messages in thread From: Stefan Kangas @ 2024-06-09 11:53 UTC (permalink / raw) To: Po Lu, emacs-devel Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes: > -static void > -read_and_dispose_of_process_output (struct Lisp_Process *p, char *chars, > - ssize_t nbytes, > - struct coding_system *coding); > +static void read_and_dispose_of_process_output (struct Lisp_Process *, char *, > + ssize_t, > + struct coding_system *); I thought we preferred the above style? > -static void read_and_insert_process_output (struct Lisp_Process *p, char *buf, > - ssize_t nread, > - struct coding_system *process_coding) > +static void > +read_and_insert_process_output (struct Lisp_Process *p, char *buf, > + ssize_t nread, > + struct coding_system *process_coding) But here we change to the other one? Could someone please explain what I'm missing? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f896c5e8cab: ; Fix coding style of last change 2024-06-09 11:53 ` master f896c5e8cab: ; Fix coding style of last change Stefan Kangas @ 2024-06-09 11:59 ` Po Lu 2024-06-11 15:05 ` Richard Stallman 1 sibling, 0 replies; 3+ messages in thread From: Po Lu @ 2024-06-09 11:59 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel Stefan Kangas <stefankangas@gmail.com> writes: > Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes: > >> -static void >> -read_and_dispose_of_process_output (struct Lisp_Process *p, char *chars, >> - ssize_t nbytes, >> - struct coding_system *coding); >> +static void read_and_dispose_of_process_output (struct Lisp_Process *, char *, >> + ssize_t, >> + struct coding_system *); > > I thought we preferred the above style? Not in declarations. > But here we change to the other one? > > Could someone please explain what I'm missing? The author evidently confused the identity of the latter with that of the former. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master f896c5e8cab: ; Fix coding style of last change 2024-06-09 11:53 ` master f896c5e8cab: ; Fix coding style of last change Stefan Kangas 2024-06-09 11:59 ` Po Lu @ 2024-06-11 15:05 ` Richard Stallman 1 sibling, 0 replies; 3+ messages in thread From: Richard Stallman @ 2024-06-11 15:05 UTC (permalink / raw) To: Stefan Kangas; +Cc: luangruo, emacs-devel [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] For a function definition, we want the function's name to start at column 0. Some tools will find it that way. For a mere declaration, we want the name NOT to start at column 0 so that it won't be taken for a definition. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-11 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171789547948.26161.15918757774801688043@vcs2.savannah.gnu.org>
[not found] ` <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org>
2024-06-09 11:53 ` master f896c5e8cab: ; Fix coding style of last change Stefan Kangas
2024-06-09 11:59 ` Po Lu
2024-06-11 15:05 ` Richard Stallman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).