From: Po Lu <luangruo@yahoo.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master f896c5e8cab: ; Fix coding style of last change
Date: Sun, 09 Jun 2024 19:59:55 +0800 [thread overview]
Message-ID: <8734pme37o.fsf@yahoo.com> (raw)
In-Reply-To: <CADwFkmnTXcNShWtvgWPEihQ+M4dVmDwYLy+4rqY7+nPh3g8K1Q@mail.gmail.com> (Stefan Kangas's message of "Sun, 9 Jun 2024 04:53:57 -0700")
Stefan Kangas <stefankangas@gmail.com> writes:
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> -static void
>> -read_and_dispose_of_process_output (struct Lisp_Process *p, char *chars,
>> - ssize_t nbytes,
>> - struct coding_system *coding);
>> +static void read_and_dispose_of_process_output (struct Lisp_Process *, char *,
>> + ssize_t,
>> + struct coding_system *);
>
> I thought we preferred the above style?
Not in declarations.
> But here we change to the other one?
>
> Could someone please explain what I'm missing?
The author evidently confused the identity of the latter with that of
the former.
next prev parent reply other threads:[~2024-06-09 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171789547948.26161.15918757774801688043@vcs2.savannah.gnu.org>
[not found] ` <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org>
2024-06-09 11:53 ` master f896c5e8cab: ; Fix coding style of last change Stefan Kangas
2024-06-09 11:59 ` Po Lu [this message]
2024-06-11 15:05 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734pme37o.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).