From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master ac797f60160 2/2: ; * lisp/net/shr.el (shr-image-zoom-levels): Fix wrong type. Date: Wed, 10 Jul 2024 11:04:05 +0200 Message-ID: <8734ohaa9m.fsf@gmail.com> References: <172054273136.24557.15429439759711990393@vcs2.savannah.gnu.org> <20240709163212.254C9C2BC9A@vcs2.savannah.gnu.org> <877cdua4ur.fsf@gmail.com> <811B0DE0-5514-436F-9D95-8F6294FB4909@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel , Jim Porter To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 10 11:05:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRTFx-0007dw-8I for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Jul 2024 11:04:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRTFF-0008MG-Tt; Wed, 10 Jul 2024 05:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRTFC-0008M4-E3 for emacs-devel@gnu.org; Wed, 10 Jul 2024 05:04:10 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRTFA-0004sM-Ta for emacs-devel@gnu.org; Wed, 10 Jul 2024 05:04:10 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42565670e20so3306815e9.0 for ; Wed, 10 Jul 2024 02:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720602247; x=1721207047; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=A2wEqNJPemQkseK2LiunrCCN2wH/6jZPkeLkVZpKkfk=; b=Hyke2o+8RA+j45MtNRsT91ZgRa7HcSplRI4Om6V+BWLjyPNV5vg5+yTIxkWer7fG48 SsamMDM1VxDdYt5zMTGUnWgQGUGYmwrgWODcU7ecsFzjyZG+IRr9Hi6HauZd1y3S2ryo ctVjJo60IOFPckYR7NpCgHTu97Mc58R9wmG9tyjobx4hL5xaylS6dXAVWIeH9lmSUaS9 kx0gH2I9rUMUWrYtG7/g0V0HSeyMdJfDK1JJ2IOX/FWepBl7+lVTrogs1aAEl/j1y51n WL3EohINyn26aF6EO6b76dVRdaHzr0Nv1HQyggJTIxD1nn5AqqmDbI0OCrvJrSyxaCWk ryFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720602247; x=1721207047; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A2wEqNJPemQkseK2LiunrCCN2wH/6jZPkeLkVZpKkfk=; b=T2bnCqdtOg8uUWXaEEHXM+CxyxPw3fGvpd0F7eCTuVC70hPTJkBsxA6o6A5VI16+wI ++lFZse6TOQwBbQVr1loiY37uZBL9qq1/YL7mwbatV9DM22l1+PYS+9Qs5acqKEnJ7eE +3TEq+mBgax8Ub4L9VkD+KP6mbhAfGM4USSZED6DzLksYko+7OIhQxYlAgMKmeq3lu83 9ZeuJgm2HyQM910u6q2Pktm6LtTAakfZJL4XCXNS0MKY/++vop/IGuhgwFWDhWqMP5Xo 5OJkIx9Oq3mu1Swh0Q5Dw1hNt52/6Gi2P+mGL3mRb9CnBODA+6pLlwRKMRElDNzXAm6F zHmw== X-Gm-Message-State: AOJu0Yz/m1p5rKU2MyA43ssIE9QBklq/oPlkYalXGYDigMJop+DemoUS 17Vb977VUT/dSomnKgjrI5ZvT+ko4jokrd3yw9qSbm7G12fyYT1X X-Google-Smtp-Source: AGHT+IESagyowZLoHWsLQ4Yxtb78xb0Vl32zcJBGcasXwTbHwyxZD0yA6AadC50XFlbjfRukwZsrXg== X-Received: by 2002:a5d:6843:0:b0:360:8281:71ef with SMTP id ffacd0b85a97d-367d2946710mr4023899f8f.4.1720602246953; Wed, 10 Jul 2024 02:04:06 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde456f5sm4812030f8f.0.2024.07.10.02.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 02:04:06 -0700 (PDT) In-Reply-To: <811B0DE0-5514-436F-9D95-8F6294FB4909@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 10 Jul 2024 10:46:56 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=rpluim@gmail.com; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321574 Archived-At: >>>>> On Wed, 10 Jul 2024 10:46:56 +0200, Mattias Engdeg=C3=A5rd said: Mattias> 9 juli 2024 kl. 18.48 skrev Robert Pluim : >> Wouldn=CA=BCt this look better: >>=20 >> :type '(repeat (radio >> (const :tag "Fit to window size" fit) >> (const :tag "Original size" original) >> (const :tag "Full image size" image) >> (const :tag "Fill window height" fill-height)))) Mattias> That's something for the original author (J.P.) to decide; I j= ust made the type agree with the value. The type agrees with the value, but not the documentation: Each element can be one of the following symbols: * `fit': Display the image at its original size as requested by the page, shrinking it to fit in the current window if necessary. * `original': Display the image at its original size as requested by the page. * `image': Display the image at its full size (ignoring the width/height specified by the HTML). * `fill-height': Display the image zoomed to fill the height of the current window." The current type lets you choose to enable each option, but not to reorder them without resorting to lisp code. Robert --=20