From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Adding new package org-menu to nongnu elpa Date: Sat, 16 Nov 2024 00:54:41 +0000 Message-ID: <8734jsvvzi.fsf@posteo.net> References: <87jzd4ehkd.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jan Rehders Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 16 01:55:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tC76H-0008bi-J9 for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Nov 2024 01:55:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tC75R-00037h-U7; Fri, 15 Nov 2024 19:54:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tC75O-00037T-AL for emacs-devel@gnu.org; Fri, 15 Nov 2024 19:54:50 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tC75K-0005xP-Qf for emacs-devel@gnu.org; Fri, 15 Nov 2024 19:54:48 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7657F240101 for ; Sat, 16 Nov 2024 01:54:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1731718483; bh=WXtfYyOmGqth+WeLHSXr7loKJbV+9XyYFTv1NXJAVog=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=MZM2aOUB57UG1BFN42+CFGsovPTFiQNIijFbJdzbL/z0cTmj3QAG/Tbt11n4cmdAN U/wqwTpgnpUQglEEprvTRHV7XXPj1izeVdZI9J6NtxlE/RPQOIq9+t9S8GOI88EJ2/ 9kZ1hKVKvWZXB+ZGt7XYoODtK5C8Se/Lei0hClAjV8BjA2iDoCcoVv32JrbXC8VZhq w7g90J0++TPCIUT0ecLM8jSF4jprAwDWLijDN9XNlS5JvM353VG1QrmfmsygKoVUR3 7iOcWqprmlAryU4OLRMtYRnVuk/4RpP+D4Uh2nHmkx5QITauPELV2ajCYDTE+JaySk nK9PuGeZCKsFA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XqwQV2ThDz6txb; Sat, 16 Nov 2024 01:54:42 +0100 (CET) In-Reply-To: (Jan Rehders's message of "Sat, 16 Nov 2024 01:20:15 +0900") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325467 Archived-At: Jan Rehders writes: > Thanks for the feedback. Applied them. Some comments: > >> + (_ (insert (format "unknown snippet type %s" snippet-id))))) ;or us= e `pcase-exhaustive'? > > Throwing an error here now to keep the info about what snippet type was n= ot found 1+ >> +;; You are require'ing yasnippet anyway, so there is no need to mess wi= th autoloads > > yasnippet should only be required dynamically if it is selected so the pl= ugin can work without it being installed Right, so it is wrong to autoload the function, as you do not want to assume that they are loadable. >> (defun org-menu-toggle-nbspace () >> "Will remove non-breaking space before/after point or insert it if non= e found." >> + ;; ^ >> + ;; Non-breaking or zero-width space? \u200b is zero-width = (used below) > > Yes that should have been zero-width space. Fixed OK, btw. I remembered that you can simplify the eval-when-compile by just writing ?\N{ZERO WIDTH SPACE} . >> +;; Can you explain why you are copying code org-colview.el? It is not >> +;; clear to me why you don't try to call it directly. > > This code used to be in lambdas and has since been moved into top-level f= unctions. Calling them now > > I=E2=80=99ve also changed the calls to deprecated functions you pointed > out. This might break with older Emacs versions but those are > supported as a best effort, only so let=E2=80=99s see if this fails for a= nyone > or if compat.el handles this Compat will probably not be of much use, as these were Org-specific functions and Compat only provides core-Emacs functions. > Thanks! > --=20 Philip Kaludercic on siskin