From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: avoid duplicates in history Date: Fri, 04 Jun 2004 22:32:04 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <871xkv3yrv.fsf@mail.jurta.org> References: <200406011700.i51H0MGK001165@scanner2.ics.uci.edu> <87llj4gguw.fsf@mail.jurta.org> <200406041629.i54GTDGK020998@scanner2.ics.uci.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1086378813 20769 80.91.224.253 (4 Jun 2004 19:53:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 Jun 2004 19:53:33 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jun 04 21:53:28 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BWKkq-0005pS-00 for ; Fri, 04 Jun 2004 21:53:28 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BWKkp-0004k3-00 for ; Fri, 04 Jun 2004 21:53:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BWKlE-00089U-L5 for emacs-devel@quimby.gnus.org; Fri, 04 Jun 2004 15:53:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BWKku-00082K-0w for emacs-devel@gnu.org; Fri, 04 Jun 2004 15:53:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BWKks-00081p-Dy for emacs-devel@gnu.org; Fri, 04 Jun 2004 15:53:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BWKks-00081m-Aw for emacs-devel@gnu.org; Fri, 04 Jun 2004 15:53:30 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BWKkH-0001dX-K3; Fri, 04 Jun 2004 15:52:54 -0400 Original-Received: from mail.jurta.org (80-235-37-117-dsl.mus.estpak.ee [80.235.37.117]) by spoon.dreamhost.com (Postfix) with ESMTP id D2B3F13D874; Fri, 4 Jun 2004 12:52:49 -0700 (PDT) Original-To: Dan Nicolaescu In-Reply-To: <200406041629.i54GTDGK020998@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 04 Jun 2004 09:29:14 -0700") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24545 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24545 Dan Nicolaescu writes: > How about the default? Should this be turned on by default? It seems reasonable to turn it on by default. > (It would be nice to have a decision about this, so I can write the > final docs and patch). When you'll write the final patch, please don't forget to make this option customizable by adding it to cus-start.el somewhere near `history-length'. And please consider the situation where your patch doesn't work. There is the following condition in `read_minibuf': /* Don't duplicate the most recent entry in the history. */ && NILP (Fequal (histstring, Fcar (histval))))) which prevents removing all duplicate elements from the history with your patch. This condition is redundant when `history-delete-duplicates' is t. -- Juri Linkov http://www.jurta.org/emacs/