From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Is that change a good idea? Date: Fri, 18 Mar 2005 08:45:49 -0500 Message-ID: <871xad5b2j.fsf-monnier+emacs@gnu.org> References: <20050318082442.GA4710@kenny.sha-bang.local> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1111154199 21780 80.91.229.2 (18 Mar 2005 13:56:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2005 13:56:39 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 18 14:56:38 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DCHxr-00083T-2P for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2005 14:56:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DCIEL-0006f4-VS for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2005 09:13:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DCIAX-0004E8-Db for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:09:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DCIAJ-00044B-0s for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:09:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DCIAH-00041Q-H3 for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:09:25 -0500 Original-Received: from [209.226.175.4] (helo=tomts16-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DCHnT-0006w1-HV for emacs-devel@gnu.org; Fri, 18 Mar 2005 08:45:51 -0500 Original-Received: from alfajor ([67.68.217.141]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050318134550.BYFR1836.tomts16-srv.bellnexxia.net@alfajor>; Fri, 18 Mar 2005 08:45:50 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id EC852D7383; Fri, 18 Mar 2005 08:45:49 -0500 (EST) Original-To: emacs-devel@gnu.org In-Reply-To: <20050318082442.GA4710@kenny.sha-bang.local> (Sascha Wilde's message of "Fri, 18 Mar 2005 09:24:42 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34720 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34720 >> > * help.el (describe-mode): Allow a :minor-mode-function property to >> > specify a different minor mode toggle function than the variable. >> > * simple.el (auto-fill-function): >> > * subr.el (add-minor-mode): Use it. >> >> > I have my doubts that the resulting flexibility is really in the best >> > interest of the users... >> >> 100% agreement. >> It's only meant to clean up the code, > Wouldn't it be far more cleaner to convert old minor-modes which would > need this hack to proper minor-modes following standard semantics? You do realize that there are packages over which we have no control, right? >> not as a new feature. > I would guess: when its there, it will be used... > btw. I posted a patch, convertinge auto-fill-function to a standard > minor-mode (thus addressing the same problem) earlier this week, but > got no response -- was it _that_ bad? No: if it were bad you'd have received complaints. I thought the code was acceptable, but at the same I found it someone unsatisfactory because there are then two variables that decide whether the mode is ON or not: auto-fill-mode and auto-fill-function and you have to make sure they're kept in sync. Maybe we could do (defvaralias 'auto-fill-function 'auto-fill-mode) and then slowly change modes to replace (if auto-fill-function (funcall auto-fill-function)) with (if auto-fill-mode (funcall normal-auto-fill-function)). Stefan