From: Michael Albinus <michael.albinus@gmx.de>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: Build failure with latest CVS
Date: Thu, 20 Apr 2006 07:08:52 +0200 [thread overview]
Message-ID: <871wvs3kbf.fsf@gmx.de> (raw)
In-Reply-To: <f7ccd24b0604180303h12ed300cn4b3539a2a98e9360@mail.gmail.com> (Juanma Barranquero's message of "Tue, 18 Apr 2006 12:03:43 +0200")
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
"Juanma Barranquero" <lekktu@gmail.com> writes:
> On 4/18/06, Andreas Schwab <schwab@suse.de> wrote:
>
>> With the latest CVS I'm getting this build failure:
>
> While waiting for a fix, I've reverted the autoload part of the
> 2006-04-17 change on net/tramp.el, so Emacs can be bootstrapped again.
I intend to fix it with the following patch. But I don't feel
confident whether it is the right way to do, a review of the patch
would be great. At least it works for me :-)
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 1511 bytes --]
Index: lisp/net/tramp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/tramp.el,v
retrieving revision 1.92
diff -u -r1.92 tramp.el
--- lisp/net/tramp.el 18 Apr 2006 10:02:40 -0000 1.92
+++ lisp/net/tramp.el 20 Apr 2006 05:06:59 -0000
@@ -4337,16 +4337,21 @@
(save-match-data (apply (cdr fn) args))
(tramp-completion-run-real-handler operation args))))
+;; Register in file name handler alist.
+;; `tramp-completion-file-name-handler' must not be active when temacs
+;; dumps. And it makes no sense in batch mode anyway.
;;;###autoload
-(put 'tramp-completion-file-name-handler 'safe-magic t)
+(defun tramp-register-file-name-handler ()
+ (unless noninteractive
+ (add-to-list 'file-name-handler-alist
+ (cons tramp-file-name-regexp 'tramp-file-name-handler))
+ (add-to-list 'file-name-handler-alist
+ (cons tramp-completion-file-name-regexp
+ 'tramp-completion-file-name-handler))
+ (put 'tramp-completion-file-name-handler 'safe-magic t)))
-;; Register in file name handler alist
-;;;###autoload
-(add-to-list 'file-name-handler-alist
- (cons tramp-file-name-regexp 'tramp-file-name-handler))
-(add-to-list 'file-name-handler-alist
- (cons tramp-completion-file-name-regexp
- 'tramp-completion-file-name-handler))
+;;;###autoload (add-hook 'emacs-startup-hook 'tramp-register-file-name-handler)
+(tramp-register-file-name-handler)
;;;###autoload
(defun tramp-unload-file-name-handler-alist ()
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-04-20 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 9:58 Build failure with latest CVS Andreas Schwab
2006-04-18 10:03 ` Juanma Barranquero
2006-04-20 5:08 ` Michael Albinus [this message]
2006-04-20 19:38 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871wvs3kbf.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).