From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: query-replace in isearch Date: Wed, 03 May 2006 23:27:32 +0300 Organization: JURTA Message-ID: <871wvavpe7.fsf@jurta.org> References: <200605030727.k437R2Wx009975@amrm2.ics.uci.edu> <87bqufwbls.fsf@jurta.org> <200605031504.k43F49hr001544@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1146688388 26680 80.91.229.2 (3 May 2006 20:33:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 May 2006 20:33:08 +0000 (UTC) Cc: emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 22:33:05 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FbO1p-0004fI-6p for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 22:32:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbO1o-00069P-JJ for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 16:32:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FbO1Y-00067U-Mt for emacs-devel@gnu.org; Wed, 03 May 2006 16:32:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FbO1X-00064y-6u for emacs-devel@gnu.org; Wed, 03 May 2006 16:32:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbO1X-00064q-4g for emacs-devel@gnu.org; Wed, 03 May 2006 16:32:39 -0400 Original-Received: from [217.25.160.1] (helo=relay1.binet.com.ua) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FbO1z-0003E1-0v for emacs-devel@gnu.org; Wed, 03 May 2006 16:33:07 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by relay1.binet.com.ua (Postfix) with ESMTP id 89B2277D5B; Wed, 3 May 2006 23:32:36 +0300 (EEST) Original-Received: from mail.binet.com.ua (i3.dialup.binet.com.ua [217.25.161.67]) by relay1.binet.com.ua (Postfix) with ESMTP id CA60E77D54; Wed, 3 May 2006 23:32:28 +0300 (EEST) Original-To: Dan Nicolaescu In-Reply-To: <200605031504.k43F49hr001544@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 03 May 2006 08:04:08 -0700") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by ClamAv at binet.com.ua X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53868 Archived-At: > This reminds me of the fact that doing `query-replace' from isearch > does not put `query-replace' in the complex command history. IMHO it > should. i.e.: C-s FOO M-% BAR RET C-x ESC ESC should show the same > thing as M-% FOO RET BAR RET C-x ESC ESC Calling `query-replace' from isearch with using `call-interactive' would add it with its arguments to the complex command history, but using `call-interactive' is not feasible here, since isearch-query-replace calls a low-level replacement function `perform-replace'. So one way to implement this I see is to use a new macro `history-push' that Kim just proposed. This is the third place where this macro would be useful. -- Juri Linkov http://www.jurta.org/emacs/