From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [cjm@pobox.com: Case-insensitive partial-completion bug] Date: Sun, 04 Mar 2007 13:30:47 -0500 Message-ID: <871wk4c148.fsf@stupidchicken.com> References: <87zmavulet.fsf@gmx.at> <17761.47567.438869.488325@manioc.csail.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173033084 582 80.91.229.12 (4 Mar 2007 18:31:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2007 18:31:24 +0000 (UTC) Cc: emacs-devel@gnu.org, Johan =?utf-8?Q?Bockg=C3=A5rd?= To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 04 19:31:18 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HNvUL-0007IW-Bl for ged-emacs-devel@m.gmane.org; Sun, 04 Mar 2007 19:31:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNvUK-00027z-Pq for ged-emacs-devel@m.gmane.org; Sun, 04 Mar 2007 13:31:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HNvUA-00027k-QT for emacs-devel@gnu.org; Sun, 04 Mar 2007 13:31:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HNvUA-00027c-Ee for emacs-devel@gnu.org; Sun, 04 Mar 2007 13:31:06 -0500 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HNvUA-0007Gg-4A; Sun, 04 Mar 2007 13:31:06 -0500 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l24IV3u3022656; Sun, 4 Mar 2007 13:31:03 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l24IUmLG017484; Sun, 4 Mar 2007 13:30:50 -0500 (EST) Original-Received: from localhost (SYDNEYPACIFIC-FIFTY-SIX.MIT.EDU [18.95.5.56]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l24IUlJ9017495; Sun, 4 Mar 2007 13:30:47 -0500 (EST) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HNvTr-0001Lb-00; Sun, 04 Mar 2007 13:30:47 -0500 In-Reply-To: (Richard Stallman's message of "Sat\, 03 Mar 2007 17\:13\:57 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.95 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67298 Archived-At: Richard Stallman writes: > I hope the bug below will get fixed. I run into it quite frequently > when reading Info: > > emacs -Q -f partial-completion-mode -f info-emacs-manual > > `g mark RET' doesn't select and exit minibuffer. > > I don't use Partial Completion mode. Is this a bug in it? > It looks that way, but I can't be sure. > > If it is, does anyone want to fix it? I think this is an oversight in the logic of `PC-do-completion'. The following patch should fix it. *** emacs/lisp/complete.el.~1.59.~ 2007-01-21 08:38:26.000000000 -0500 --- emacs/lisp/complete.el 2007-03-04 13:28:25.000000000 -0500 *************** *** 404,411 **** ;; Check if buffer contents can already be considered complete (if (and (eq mode 'exit) ! (test-completion-ignore-case str table pred)) ! 'complete ;; Do substitutions in directory names (and filename --- 404,418 ---- ;; Check if buffer contents can already be considered complete (if (and (eq mode 'exit) ! (test-completion str table pred)) ! (progn ! ;; If completion-ignore-case is non-nil, insert the ! ;; completion string since that may have a different case. ! (when completion-ignore-case ! (setq str (try-completion str table pred)) ! (delete-region beg end) ! (insert str)) ! 'complete) ;; Do substitutions in directory names (and filename